Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 6452 : Use placeholders in sql but makepayment seems dead code ?

Browse source 
Signed-off-by: Frre Sbastien Marie <semarie-koha@latrappe.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This commit is contained in:
Frère Sébastien Marie 2011-02-27 15:24:53 +01:00 committed by Chris Cormack
parent 8c9645b1f9
commit 4475e9a675
1 changed files with 11 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
C4/Accounts.pm
View file

@ -169,13 +169,11 @@ sub makepayment {
my $data = $sth->fetchrow_hashref;
$sth->finish;
$dbh->do(
"UPDATE accountlines
SET amountoutstanding = 0
WHERE borrowernumber = $borrowernumber
AND accountno = $accountno
"
);
my $sth = $dbh->prepare("UPDATE accountlines
SET amountoutstanding = 0
WHERE borrowernumber = ?
AND accountno = ?");
$sth->execute($borrowernumber, $accountno);
# print $updquery;
# $dbh->do( "
@ -187,20 +185,18 @@ sub makepayment {
# create new line
my $payment = 0 - $amount;
$dbh->do( "
INSERT INTO accountlines
(borrowernumber, accountno, date, amount,
description, accounttype, amountoutstanding)
VALUES ($borrowernumber, $nextaccntno, now(), $payment,
'Payment,thanks - $user', 'Pay', 0)
" );
my $sth = $dbh->prepare("INSERT INTO accountlines
(borrowernumber, accountno, date, amount,
description, accounttype, amountoutstanding)
VALUES (?,?,now(),?,?,'Pay',0)");
$sth->execute($borrowernumber, $nextaccntno, $payment, "Payment,thanks - $user");
# FIXME - The second argument to &UpdateStats is supposed to be the
# branch code.
# UpdateStats is now being passed $accountno too. MTJ
UpdateStats( $user, 'payment', $amount, '', '', '', $borrowernumber,
$accountno );
$sth->finish;
#from perldoc: for SELECT only #$sth->finish;
#check to see what accounttype
if ( $data->{'accounttype'} eq 'Rep' || $data->{'accounttype'} eq 'L' ) {