Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34068: Fix tests

Browse source 
Several wrong things in the previous attempt:
* as_list returns an array
* as_list returns objects, ->{library_id} does not exist
* as_list does not returns api object, you need to call ->branchcode to
  get the id
* $pickup_locations defined for both situations was confusing

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2024-11-06 11:57:42 +01:00 committed by Katrin Fischer
parent 04c095c473
commit 44b29d114f
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Koha/REST/V1/Holds.pm
View file

@ -462,20 +462,18 @@ sub pickup_locations {
$ps_set = $hold->biblio->pickup_locations( { patron => $hold->patron } );
}
my $pickup_locations;
my @response = ();
if ( C4::Context->preference('AllowHoldPolicyOverride') ) {
$pickup_locations = $ps_set->as_list;
my $libraries_rs = Koha::Libraries->search( { pickup_location => 1 } );
my $libraries = $c->objects->search($libraries_rs);
@response = map {
my $library = $_;
$library->{needs_override} = (
any { $_->{library_id} eq $library->{library_id} }
@{$pickup_locations}
any { $_->branchcode eq $library->{library_id} }
$ps_set->as_list
)
? Mojo::JSON->false
: Mojo::JSON->true;
@ -488,7 +486,7 @@ sub pickup_locations {
);
}
$pickup_locations = $c->objects->search( $ps_set );
my $pickup_locations = $c->objects->search( $ps_set );
@response = map { $_->{needs_override} = Mojo::JSON->false; $_; } @{$pickup_locations};
return $c->render(