From 4604f595d66f65ba15d6625b2366acb147797ffc Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 23 Oct 2013 16:48:14 +0200 Subject: [PATCH] Bug 11124: disallow trying to run the staff benchmark script as the DB account On step 6 (at least), the circulation and return page redirect to the select branch page and nothing is done. The script should die if the user used is the sql administrator account. Test plan: Suppose that the sql admin account is root/root and koha/koha a superlibrarian account. 1/ perl misc/load_testing/benchmark_staff.pl --steps=6 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: ... Step 6 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="root" --user="root" should produce: Authentication successful You cannot use the database administrator account to launch this script Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton --- misc/load_testing/benchmark_staff.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/misc/load_testing/benchmark_staff.pl b/misc/load_testing/benchmark_staff.pl index 786b04a21b..6ccaa4926d 100644 --- a/misc/load_testing/benchmark_staff.pl +++ b/misc/load_testing/benchmark_staff.pl @@ -18,6 +18,7 @@ use Data::Dumper; use HTTP::Cookies; use C4::Context; use C4::Debug; +use C4::Members qw ( GetMember ); use URI::Escape; my ($help, $steps, $baseurl, $max_tries, $user, $password,$short_print); @@ -89,6 +90,9 @@ if( $resp->is_success and $resp->content =~ m|ok| ) { die "Authentication failure: \n\t" . $resp->status_line; } +die "You cannot use the database administrator account to launch this script" + unless defined C4::Members::GetMember(userid => $user); + # remove some unnecessary garbage from the cookie $cookie =~ s/ path_spec; discard; version=0//; $cookie =~ s/Set-Cookie3: //;