Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25936: (follow-up) Unit test for store

Browse source 
This unit test confirms that we are not triggering the Password Change
notification notice upon patron creations.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2022-10-04 12:01:47 +01:00 committed by Tomas Cohen Arazi
parent 6b732f91b5
commit 48054327a1
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
t/db_dependent/Koha/Patrons.t
View file

@ -1865,7 +1865,7 @@ subtest 'Test Koha::Patrons::merge' => sub {
};
subtest '->store' => sub {
plan tests => 7;
plan tests => 8;
my $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;
@ -1921,6 +1921,40 @@ subtest '->store' => sub {
is($logs->count, 0, '->store should not have generated a log for updated_on') or diag 'Log generated:'.Dumper($logs->unblessed);
$schema->storage->txn_rollback;
};
subtest 'create user usage' => sub {
plan tests => 1;
$schema->storage->txn_begin;
my $library = $builder->build_object( { class => 'Koha::Libraries' } );
my $patron_category = $builder->build_object(
{
class => 'Koha::Patron::Categories',
value => { category_type => 'P', enrolmentfee => 0 }
}
);
my %data = (
cardnumber => "123456789",
firstname => "Tômàsító",
surname => "Ñoné",
password => 'Funk3y',
categorycode => $patron_category->categorycode,
branchcode => $library->branchcode,
);
# Enable notifying patrons of password changes for these tests
t::lib::Mocks::mock_preference( 'NotifyPasswordChange', 1 );
my $new_patron = Koha::Patron->new( \%data )->store();
my $queued_notices = Koha::Notice::Messages->search(
{ borrowernumber => $new_patron->borrowernumber }
);
is(
$queued_notices->count, 0,
"No notice queued when NotifyPasswordChange enabled and this is a new patron"
);
$schema->storage->txn_rollback;
};
};
subtest '->set_password' => sub {