Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33028: Perltidy database update script

Browse source 
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit f0a3b98cdb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Katrin Fischer 2023-07-11 13:23:40 +00:00 committed by Fridolin Somers
parent 0bd5fb0bb6
commit 495a4a7477
1 changed files with 20 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
installer/data/mysql/atomicupdate/fix_calc_fines_fr-currency_21-11-MT39815.pl
View file

@ -1,32 +1,39 @@
use Modern::Perl;
return {
bug_number => "33028",
bug_number => "33028",
description => "Fix wrongly formatted values for monetary values in circulation rules",
up => sub {
up => sub {
my ($args) = @_;
my ($dbh, $out) = @$args{qw(dbh out)};
my ( $dbh, $out ) = @$args{qw(dbh out)};
my $rules = $dbh->selectall_arrayref(
q|SELECT * FROM circulation_rules WHERE rule_name IN ('fine', 'overduefinescap', 'recall_overdue_fine', 'article_request_fee')|,
{ Slice => {} }
);
my $query = $dbh->prepare(
"UPDATE circulation_rules SET rule_value = ? WHERE id = ?");
my $query = $dbh->prepare("UPDATE circulation_rules SET rule_value = ? WHERE id = ?");
my $error;
for my $rule ( @{$rules} ) {
my $library = defined($rule->{'branchcode'}) ? $rule->{'branchcode'} : "All";
my $category = defined($rule->{'categorycode'}) ? $rule->{'categorycode'} : "All";
my $itemtype = defined($rule->{'itemtype'}) ? $rule->{'itemtype'} : "All";
if ( !( $rule->{'rule_value'} =~ /^[0-9.]*$/ )) {
$error .= "Rule ID: $rule->{'id'} ($library-$category-$itemtype) \tRule: $rule->{'rule_name'}\tValue: $rule->{'rule_value'}\n";
my $library =
defined( $rule->{'branchcode'} ) ? $rule->{'branchcode'} : "All";
my $category =
defined( $rule->{'categorycode'} )
? $rule->{'categorycode'}
: "All";
my $itemtype =
defined( $rule->{'itemtype'} ) ? $rule->{'itemtype'} : "All";
if ( !( $rule->{'rule_value'} =~ /^[0-9.]*$/ ) ) {
$error .=
"Rule ID: $rule->{'id'} ($library-$category-$itemtype) \tRule: $rule->{'rule_name'}\tValue: $rule->{'rule_value'}\n";
}
}
if ( $error ) {
die("Circulation rules contain invalid monetary values:\n$error\nPlease fix these before you restart the update.");
if ($error) {
die(
"Circulation rules contain invalid monetary values:\n$error\nPlease fix these before you restart the update."
);
}
say $out "Circulation rules have been validated. All circulation rule values are correctly formatted.";
},
};
};