Bug 23463: Fix failing tests

And adding a FIXME about discard_changes

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

t/db_dependent/Circulation/IsItemIssued.t

@@ -76,6 +76,8 @@ is(
 AddReturn($item->barcode, $library->{branchcode});
 is ( IsItemIssued( $item->itemnumber ), 0, "item has been returned" );
 
+$item->discard_changes; # FIXME We should not need that
+                        # If we do not, $self->checkout in safe_to_delete will not know the item has been checked out
 is(
     $item->safe_delete,
     1,

t/db_dependent/Items_DelItemCheck.t

@@ -117,6 +117,7 @@ AddReturn( $item->barcode, $branch->{branchcode} );
 t::lib::Mocks::mock_preference('IndependentBranches', 1);
 $item->set( { homebranch => $branch2->{branchcode}, holdingbranch => $branch2->{branchcode} })->store;
 
+$item->discard_changes;
 is(
     $item->safe_to_delete,
     'not_same_branch',