Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags

Browse source 
This correction fixes the previous patch which was dumb and stupid.

This patch adds a default font family "sans-serif" to the OPAC CSS as a
workaround for this Firefox bug:

font-family isn't honored in `<option>` element within `<select>`
dropdown
https://bugzilla.mozilla.org/show_bug.cgi?id=1536148

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Open the OPAC main page in Firefox.
 - Click the search type dropdown. The options should be styled using
   your system's default sans-serif font rather than a serif font.
 - Check that other areas of the OPAC are still styled with the correct
   "NotoSans" font. An error with this patch should be obvious when
   looking at a logged-in user's checkouts.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Owen Leonard 2021-04-07 13:43:40 +00:00 committed by Jonathan Druart
parent 34575f1f1a
commit 4cc224baa7
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
View file

@ -1072,7 +1072,7 @@ button {
option,
select,
textarea {
font-family: "NotoSans";
font-family: "NotoSans", sans-serif;
}
}

8
koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss
View file

@ -1,5 +1,5 @@
@font-face {
font-family: "NotoSans, sans-serif";
font-family: "NotoSans";
font-style: normal;
font-weight: 400;
src: local("Noto Sans Regular"),
@ -8,7 +8,7 @@
}
@font-face {
font-family: "NotoSans, sans-serif";
font-family: "NotoSans";
font-style: bold;
font-weight: 700;
src: local("Noto Sans Bold"),
@ -17,7 +17,7 @@
}
@font-face {
font-family: "NotoSans, sans-serif";
font-family: "NotoSans";
font-style: italic;
font-weight: 400;
src: local("Noto Sans Italic"),
@ -26,7 +26,7 @@
}
@font-face {
font-family: "NotoSans, sans-serif";
font-family: "NotoSans";
font-style: italic;
font-weight: 700;
src: local("Noto Sans Bold Italic"),