Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15030 - Certain values in serials' items are lost on next edit

Browse source 
When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box.  If not noticed, the value will be overwritten on the next save.

Test:
- Create a subscription
- Edit itemcallnumber (952o?) and make sure to have a different value than the default one.
- Save.
- Edit it again
- The saved value is not there.

This is true for itemcallnumber and a few other fields.

This was caused by calls to ->field($subfield).  This would always fail, of course.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Blou 2015-10-19 12:16:05 -04:00 committed by Kyle M Hall
parent 4f178fad53
commit 4cdcdb3cb5
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
C4/Items.pm
View file

@ -2936,7 +2936,7 @@ sub PrepareItemrecordDisplay {
if ( $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.itemcallnumber'
&& $defaultvalues
&& $defaultvalues->{'callnumber'} ) {
if( $itemrecord and $defaultvalues and not $itemrecord->field($subfield) ){
if( $itemrecord and $defaultvalues and not $itemrecord->subfield($tag,$subfield) ){
# if the item record exists, only use default value if the item has no callnumber
$defaultvalue = $defaultvalues->{callnumber};
} elsif ( !$itemrecord and $defaultvalues ) {
@ -2947,7 +2947,7 @@ sub PrepareItemrecordDisplay {
if ( ( $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.holdingbranch' || $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.homebranch' )
&& $defaultvalues
&& $defaultvalues->{'branchcode'} ) {
if ( $itemrecord and $defaultvalues and not $itemrecord->field($subfield) ) {
if ( $itemrecord and $defaultvalues and not $itemrecord->subfield($tag,$subfield) ) {
$defaultvalue = $defaultvalues->{branchcode};
}
}
@ -2955,7 +2955,7 @@ sub PrepareItemrecordDisplay {
&& $defaultvalues
&& $defaultvalues->{'location'} ) {
if ( $itemrecord and $defaultvalues and not $itemrecord->field($subfield) ) {
if ( $itemrecord and $defaultvalues and not $itemrecord->subfield($tag,$subfield) ) {
# if the item record exists, only use default value if the item has no locationr
$defaultvalue = $defaultvalues->{location};
} elsif ( !$itemrecord and $defaultvalues ) {