Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 26010: Remove the use of jquery.checkboxes plugin from staff interface cart

Browse source 
This patch removes the use of the jquery.checkboxes plugin from the
staff interface cart and replaces its functionality with "plain" jQuery.

To test, apply the patch and add some items to the Cart in the staff
interface.

- Open the Cart window in the staff interface by clicking the "Cart"
  link in the header.
- Test that the "Select all" and "Clear all" links work correctly to
  check and uncheck all checkboxes.
- Test that the "Remove" or "Place hold" controls work correctly,
  applying to only the checked checkboxes whether they were checked
  using "Select all" or by manually checking them.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Owen Leonard 2020-07-17 17:29:15 +00:00 committed by Jonathan Druart
parent b332e0912d
commit 4cf5ef239f
2 changed files with 13 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
View file

@ -322,7 +322,6 @@
[% INCLUDE js_includes.inc %]
[% INCLUDE 'datatables.inc' %]
[% Asset.js("js/cart.js") | $raw %]
[% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
</body>
</html>

29
koha-tmpl/intranet-tmpl/prog/js/cart.js
View file

@ -66,24 +66,21 @@ function batchModify(){
$(document).ready(function(){
$("#items-popover").popover();
$("#CheckAll").click(function(){
var checked = [];
$("#bookbag_form").checkCheckboxes("*", true).each(
function() {
$(this).change();
}
);
return false;
$("#CheckAll").click(function (e) {
e.preventDefault();
$(".select_record").each(function () {
$(this).prop("checked", true).change();
});
});
$("#CheckNone").click(function(){
var checked = [];
$("#bookbag_form").unCheckCheckboxes("*",true).each(
function() {
$(this).change();
}
);
return false;
$("#CheckNone").click(function (e) {
e.preventDefault();
$(".select_record").each(function () {
$(this).prop("checked", false).change();
});
});
$(".holdsep").text("| ");
$(".hold").text(_("Place hold"));
$("#downloadcartc").empty();