Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30205: Add subtitle to subscription detail page

Browse source 
To test:
1. Make some new serial subscriptions and connect them to biblios that contain subtitles.
2. Do a serial search that will return your newly created subscription.
3. Click on one of those subscription to be taken to the subscription detail page.
4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place
5. Apply patch, restart_all, and reload the subscription detail page.
6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Lucas Gass 2022-03-01 16:30:04 +00:00 committed by Fridolin Somers
parent 17a14b3c1f
commit 4ec5a186a2
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
C4/Serials.pm
View file

@ -269,6 +269,7 @@ sub GetSubscription {
subscriptionhistory.*, subscriptionhistory.*,
aqbooksellers.name AS aqbooksellername, aqbooksellers.name AS aqbooksellername,
biblio.title AS bibliotitle, biblio.title AS bibliotitle,
biblio.subtitle AS bibliosubtitle,
subscription.biblionumber as bibnum subscription.biblionumber as bibnum
FROM subscription FROM subscription
LEFT JOIN subscriptionhistory ON subscription.subscriptionid=subscriptionhistory.subscriptionid LEFT JOIN subscriptionhistory ON subscription.subscriptionid=subscriptionhistory.subscriptionid

4
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
View file

@ -50,7 +50,7 @@
[% INCLUDE 'serials-toolbar.inc' %] [% INCLUDE 'serials-toolbar.inc' %]
[% INCLUDE 'mana/mana-comment-status.inc' %] [% INCLUDE 'mana/mana-comment-status.inc' %]
<h1>Subscription for [% bibliotitle | html %] [% IF closed %](closed)[% END %]</h1> <h1>Subscription for [% bibliotitle | html %] [% bibliosubtitle | html %] [% IF closed %](closed)[% END %]</h1>
[% IF ( abouttoexpire ) %] [% IF ( abouttoexpire ) %]
[% UNLESS closed %] [% UNLESS closed %]
@ -111,7 +111,7 @@
<li><span class="label">Subscription ID: </span>[% subscriptionid | html %]</li> <li><span class="label">Subscription ID: </span>[% subscriptionid | html %]</li>
<li><span class="label">Librarian identity:</span> [% librarian | html %]</li> <li><span class="label">Librarian identity:</span> [% librarian | html %]</li>
<li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid | uri %]">[% aqbooksellername | html %]</a></li> <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid | uri %]">[% aqbooksellername | html %]</a></li>
<li><span class="label">Biblio:</span> <a href="[% PROCESS biblio_a_href biblionumber => bibnum %]">[% bibliotitle | html %]</a> <em>([% bibnum | html %])</em></li> <li><span class="label">Biblio:</span> <a href="[% PROCESS biblio_a_href biblionumber => bibnum %]">[% bibliotitle | html %] [% bibliosubtitle | html %]</a> <em>([% bibnum | html %])</em></li>
[% IF ( OPACBaseURL ) %] [% IF ( OPACBaseURL ) %]
<li> <li>
<span class="label">OPAC view:</span> <span class="label">OPAC view:</span>