From 5083d5752c2413cc265c6e9682539e6495c7c906 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Fri, 14 Jun 2024 10:03:22 -0400 Subject: [PATCH] Bug 37089: cud-delete_confirm should not be cud Adjust aqbudgets.pl and currency.pl to check for the correct op value To test: Part 1 - Delete a fund 1. Go to Acquisitions > Funds 2. Try to delete a fund --> Confirmation page shows fund name as '' and fund amount as 0.00 3. Click "Yes, delete this fund" --> The fund is still there Part 2 - Delete a currency 3. Go to Acquisitions > Currencies 4. Try to delete a currency --> Confirmation shows empty values for currency and rate 5. Click, "Yes, delete this currency" --> An error message appears and the currency is not deleted 6. Apply patch and restart_all 7. Repeat steps 1-5 --> Confirmation pages display correct information, and deletions occur successfully Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer --- admin/aqbudgets.pl | 2 +- admin/currency.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl index e32b3533a3..6a1df616fc 100755 --- a/admin/aqbudgets.pl +++ b/admin/aqbudgets.pl @@ -185,7 +185,7 @@ if ($op eq 'add_form') { #---------------------- DEFAULT DISPLAY BELOW --------------------- # called by default form, used to confirm deletion of data in DB -} elsif ($op eq 'cud-delete_confirm') { +} elsif ($op eq 'delete_confirm') { my $budget = GetBudget($budget_id); $template->param( diff --git a/admin/currency.pl b/admin/currency.pl index b706ae0291..6220bbd081 100755 --- a/admin/currency.pl +++ b/admin/currency.pl @@ -91,7 +91,7 @@ if ( $op eq 'add_form' ) { } $searchfield = q||; $op = 'list'; -} elsif ( $op eq 'cud-delete_confirm' ) { +} elsif ( $op eq 'delete_confirm' ) { my $currency = Koha::Acquisition::Currencies->find($currency_code); my $nb_of_orders = Koha::Acquisition::Orders->search( { currency => $currency->currency } )->count;