Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13437: Trivial edits on marc21 plugins before conversion

Browse source 
marc21_field_003.pl: copy-pasta comment about date removed
marc21_field_005.pl: commented use removed
marc21_field_006.pl: old/irrelevant pod lines
marc21_field_007.pl: old/irrelevant pod lines
marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice
marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines
marc21_field_040c.pl: two commented lines removed
marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod
marc21_field_245h.pl: whitespace

marc21_linking_section.pl: relocated some comment lines, and replaced a new
CGI object by the one passed in via the plugin launcher (agreed, this may
not be so trivial as the other changes)

Test plan:
These (trivial) changes are hard to test.
Pick a few plugins and verify that behavior is not changed in the marc
editor.
For the brave: Try marc21_linking_section.pl.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tried marc21_linking_section.pl :)
(ling plugin to 773$9, create new record, search for parent and check values inserted)
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Marcel de Rooy 2015-05-13 13:47:38 +02:00 committed by Tomas Cohen Arazi
parent efe5266625
commit 51197e9f18
10 changed files with 11 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cataloguing/value_builder/marc21_field_003.pl
View file

@ -26,7 +26,6 @@ sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $function_name= $field_number;
# find today's date
my $org = C4::Context->preference('MARCOrgCode');
my $res = "
<script type=\"text/javascript\">

1
cataloguing/value_builder/marc21_field_005.pl
View file

@ -19,7 +19,6 @@
use strict;
#use warnings; FIXME - Bug 2505
#use C4::Context;
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;

6
cataloguing/value_builder/marc21_field_006.pl
View file

@ -28,12 +28,6 @@ use C4::Output;
use XML::LibXML;
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ($dbh, $record, $tagslib, $field_number, $tabloop) = @_;
my $function_name = $field_number;

6
cataloguing/value_builder/marc21_field_007.pl
View file

@ -27,12 +27,6 @@ use C4::Context;
use C4::Search;
use C4::Output;
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
my $function_name = $field_number;

11
cataloguing/value_builder/marc21_field_008.pl
View file

@ -29,18 +29,13 @@ use C4::Output;
use XML::LibXML;
use Koha::Util::FrameworkPlugin qw|date_entered|;
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ($dbh, $record, $tagslib, $field_number, $tabloop) = @_;
my $lang = C4::Context->preference('DefaultLanguageField008' );
$lang = "eng" unless $lang;
$lang = pack("A3", $lang);
my ($dbh, $record, $tagslib, $field_number, $tabloop) = @_;
my $function_name = $field_number;
my $dateentered = date_entered();
my $res = "
@ -76,11 +71,11 @@ function Clic$function_name(i) {
}
sub plugin {
my ($input) = @_;
my $lang = C4::Context->preference('DefaultLanguageField008' );
$lang = "eng" unless $lang;
$lang = pack("A3", $lang);
my ($input) = @_;
my $index = $input->param('index');
my $result = $input->param('result');
my $leader = $input->param('leader');

7
cataloguing/value_builder/marc21_field_008_authorities.pl
View file

@ -30,12 +30,6 @@ use Koha::Util::FrameworkPlugin qw|date_entered|;
use constant FIXLEN_DATA_ELTS => '|| aca||aabn | a|a d';
use constant PREF_008 => 'MARCAuthorityControlField008';
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $function_name= $field_number;
@ -69,6 +63,7 @@ function Clic$function_name(i) {
return ($function_name,$res);
}
sub plugin {
my ($input) = @_;
my $index= $input->param('index');

2
cataloguing/value_builder/marc21_field_040c.pl
View file

@ -20,13 +20,11 @@
use strict;
#use warnings; FIXME - Bug 2505
use C4::Context;
# use MARC::Record;
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $function_name= $field_number;
# find today's date
my $org = C4::Context->preference('MARCOrgCode');
my $res = "
<script type=\"text/javascript\">

11
cataloguing/value_builder/marc21_field_040d.pl
View file

@ -1,6 +1,5 @@
#!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
@ -21,19 +20,11 @@
use strict;
#use warnings; FIXME - Bug 2505
use C4::Context;
# use MARC::Record;
=head1 DESCRIPTION
plugin_parameters : other parameters added when the plugin is called by the dopop function
=cut
sub plugin_javascript {
my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
my $function_name = $field_number;
# find today's date
my $org = C4::Context->preference('MARCOrgCode');
my $res = "
<script type=\"text/javascript\">
@ -47,5 +38,5 @@ function Focus$function_name(subfield_managed) {
//]]>
</script>
";
return ($function_name,$res);
return ($function_name,$res);
}

3
cataloguing/value_builder/marc21_field_245h.pl
View file

@ -1,6 +1,5 @@
#!/usr/bin/perl
# Copyright 2009 Kyle Hall <kyle.m.hall@gmail.com>
#
# This file is part of Koha.
@ -44,5 +43,5 @@ function Blur$function_name(index) {
//]]>
</script>
";
return ($function_name,$res);
return ($function_name,$res);
}

15
cataloguing/value_builder/marc21_linking_section.pl
View file

@ -49,19 +49,14 @@ sub plugin_javascript {
return ( $function_name, $res );
}
# sub plugin
#
# input arg :
# -- op could be equals to
# * fillinput :
# * do_search :
#
sub plugin {
my ($input) = @_;
my ($query) = @_;
my $dbh = C4::Context->dbh;
my $query = new CGI;
my $op = $query->param('op');
# -- op could be equal to
# * fillinput
# * do_search
my $type = $query->param('type');
my $startfrom = $query->param('startfrom');
$startfrom = 0 if ( !defined $startfrom );