Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 19194: Check itemtype is defined when receiving an order

Browse source 
To test:
1) Find a record with an item that has no itemtype (or remove the
itemtype of an item)
2) Go to Acquisitions -> Find a vendor or make a new one -> create a new
basket
3) Add the record from Step 1 to your basket
4) Close the basket
5) Go back to the vendor and click 'Receive shipments'
6) Put in an invoice number, click Next
7) Click the Receive link for your item
8) Confirm you see an internal server error
9) Apply the patch and refresh the page
10) The error should be gone and behaviour should continue as expected

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Aleisha Amohia 2017-08-29 04:51:40 +00:00 committed by Jonathan Druart
parent d510598076
commit 51a65731c0
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
acqui/orderreceive.pl
View file

@ -147,7 +147,9 @@ if ($AcqCreateItem eq 'receiving') {
$item->{materials} = $descriptions->{lib} // '';
my $itemtype = Koha::ItemTypes->find( $item->{itype} );
$item->{itemtype} = $itemtype->description; # FIXME Should not it be translated_description?
if (defined $itemtype) {
$item->{itemtype} = $itemtype->description; # FIXME Should not it be translated_description?
}
push @items, $item;
}
$template->param(items => \@items);