Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29356: Pickup location dropdowns should perform 'contains' searches

Browse source 
When placing a hold, the dropdowns for selecting a pickup library automatically right-truncate, so one can type "cen" and find Centerville.

On the Libraries page in Admin, however, the search box both left- and
right-truncates, so one can type "en" and find Centerville.

This patch makes the search perform 'contains' searches.

To test:
1. Try placing a hold. Make sure your rules allow Centerville to be a
   valid pickup location.
2. Search 'cen'
=> SUCCESS: Centerville shows
3. Search 'en
=> FAIL: Centerville doesn't show
4. Apply this patch and reload
5. Repeat 2
=> SUCCESS: Works!
6. Repeat 3
=> SUCCSS: Centerville shows!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomás Cohen Arazi 2021-10-28 15:32:04 -03:00 committed by Jonathan Druart
parent 413d882488
commit 51f42b8734
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View file

@ -1260,7 +1260,7 @@
data: function (params) { data: function (params) {
var search_term = (params.term === undefined) ? '' : params.term; var search_term = (params.term === undefined) ? '' : params.term;
var query = { var query = {
"q": JSON.stringify({"name":{"-like":search_term+'%'}}), "q": JSON.stringify({"name":{"-like":'%'+search_term+'%'}}),
"_order_by": "name", "_order_by": "name",
"_per_page": -1 "_per_page": -1
}; };
@ -1322,7 +1322,7 @@
data: function (params) { data: function (params) {
var search_term = (params.term === undefined) ? '' : params.term; var search_term = (params.term === undefined) ? '' : params.term;
var query = { var query = {
"q": JSON.stringify({"name":{"-like":search_term+'%'}}), "q": JSON.stringify({"name":{"-like":'%'+search_term+'%'}}),
"_order_by": "name", "_order_by": "name",
"patron_id": patron_id, "patron_id": patron_id,
"_per_page": -1 "_per_page": -1
@ -1360,7 +1360,7 @@
data: function (params) { data: function (params) {
var search_term = (params.term === undefined) ? '' : params.term; var search_term = (params.term === undefined) ? '' : params.term;
var query = { var query = {
"q": JSON.stringify({"name":{"-like":search_term+'%'}}), "q": JSON.stringify({"name":{"-like":'%'+search_term+'%'}}),
"_order_by": "name", "_order_by": "name",
"patron_id": patron_id, "patron_id": patron_id,
"_per_page": -1 "_per_page": -1

2
koha-tmpl/intranet-tmpl/prog/js/holds.js
View file

@ -249,7 +249,7 @@ $(document).ready(function() {
data: function (params) { data: function (params) {
var search_term = (params.term === undefined) ? '' : params.term; var search_term = (params.term === undefined) ? '' : params.term;
var query = { var query = {
"q": JSON.stringify({"name":{"-like":search_term+'%'}}), "q": JSON.stringify({"name":{"-like":'%'+search_term+'%'}}),
"_order_by": "name", "_order_by": "name",
"_per_page": -1 "_per_page": -1
}; };