Bug 33883: "Make sure to copy your API secret" message overlaps text

This patch updates the markup on the patron API keys page so that it
uses standard classes for dialogs and page sections.

To test you must have RESTOAuth2ClientCredentials enabled.

- Apply the patch and locate a patron record.
- From their checkout or detail page, choose More -> Manage API keys
- Click "Generate a new client id/secret pair"
- Enter a description and click Save.
- You should see a message in a standard message-style dialog, "Make
  sure to copy your API secret now. You won’t be able to see it again!"
- The API key information should be displayed in a .page-section div.
- The table of existing keys should be displayed in a .page-section div.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-06-02 14:00:34 +00:00 committed by Tomas Cohen Arazi
parent 087861cb43
commit 536f860038
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F

View file

@ -36,8 +36,8 @@
[% IF fresh_api_key %] [% IF fresh_api_key %]
[%# A fresh api key was generated, display the secret, only once %] [%# A fresh api key was generated, display the secret, only once %]
<div class="rows"> <div class="dialog message">Make sure to copy your API secret now. You wont be able to see it again!</div>
<span class="alert">Make sure to copy your API secret now. You wont be able to see it again!</span> <div class="page-section rows">
<ol> <ol>
<li> <li>
<span class="label">Description: </span> <span class="label">Description: </span>
@ -72,8 +72,8 @@
</fieldset> </fieldset>
</form> </form>
<div id="keys">
[% IF api_keys.count %] [% IF api_keys.count %]
<div class="page-section" id="keys">
<p> <p>
<button class="btn btn-default toggle_element" type="submit" id="show-api-form" data-element="#add-api-key"><i class="fa fa-plus"></i> Generate a new client id/key pair</button> <button class="btn btn-default toggle_element" type="submit" id="show-api-form" data-element="#add-api-key"><i class="fa fa-plus"></i> Generate a new client id/key pair</button>
</p> </p>
@ -117,18 +117,18 @@
[% END %] [% END %]
</tbody> </tbody>
</table> </table>
</div> <!-- /#keys.page-section -->
[% ELSE %] [% ELSE %]
<div class="dialog message"> <div class="dialog message">
<div>No keys defined for the current patron.</div> <p>No keys defined for the current patron.</p>
<div> <p>
<a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"> <a href="#" class="btn btn-default toggle_element" data-element="#add-api-key" id="show-api-form">
<i class="fa fa-plus"></i> <i class="fa fa-plus"></i>
<span>Generate a new client id/secret pair</span> <span>Generate a new client id/secret pair</span>
</a> </a>
<div> <p>
</div>
[% END %]
</div> </div>
[% END # /IF api_keys.count %]
</main> </main>
</div> <!-- /.col-sm-10.col-sm-push-2 --> </div> <!-- /.col-sm-10.col-sm-push-2 -->