Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30828: Remove useless 'type' parameter in placerequest.pl

Browse source 
To test:
 1) Grep for placerequest.pl in the source code and check that
    request.tt is the only place where the type parameter is passed.

Signed-off-by: David Nind <david@davidnind.com>

JD amended patch: adjust commit title
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Joonas Kylmälä 2022-05-21 19:23:32 +00:00 committed by Tomas Cohen Arazi
parent 72dcf17ea0
commit 54a6c73c6d
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View file

@ -445,8 +445,6 @@
<form action="placerequest.pl" method="post" name="form" id="hold-request-form"> <form action="placerequest.pl" method="post" name="form" id="hold-request-form">
<input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" /> <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" />
<input type="hidden" name="type" value="str8" />
[% FOREACH biblionumber IN biblionumbers %] [% FOREACH biblionumber IN biblionumbers %]
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]"/> <input type="hidden" name="biblionumber" value="[% biblionumber | html %]"/>
[% END %] [% END %]

3
reserve/placerequest.pl
View file

@ -43,7 +43,6 @@ my $notes = $input->param('notes');
my $branch = $input->param('pickup'); my $branch = $input->param('pickup');
my $startdate = $input->param('reserve_date') || ''; my $startdate = $input->param('reserve_date') || '';
my @rank = $input->multi_param('rank-request'); my @rank = $input->multi_param('rank-request');
my $type = $input->param('type');
my $title = $input->param('title'); my $title = $input->param('title');
my $checkitem = $input->param('checkitem'); my $checkitem = $input->param('checkitem');
my $expirationdate = $input->param('expiration_date'); my $expirationdate = $input->param('expiration_date');
@ -65,7 +64,7 @@ foreach my $bibnum ( @holdable_bibs ) {
my $found; my $found;
if ( $type eq 'str8' && $patron ) { if ( $patron ) {
foreach my $biblionumber ( keys %bibinfos ) { foreach my $biblionumber ( keys %bibinfos ) {