From 554efbe35483dbc3dd7615f7feeaa6edf14619e6 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 18 Jul 2024 12:54:30 +0000 Subject: [PATCH] Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item Upadates for CSRF are inadvertently stopping AddReturn from being trigger when a hold is canceled. This is necessary to generate the transfer back to the originating library. Test Plan: 1) Find item with a waiting hold, and check it in 2) In the popup notifying me of the waiting hold, select 'Cancel hold' 3) Note no second popup appears notifying you of the need to transfer the item to its home library 4) Apply this patch 5) Restart all the things! 6) Repeat steps 1-2 7) Second popup appears! Signed-off-by: Lucas Gass Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize --- circ/returns.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/returns.pl b/circ/returns.pl index 019d8e36c8..f3182464df 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -293,7 +293,7 @@ if ($transit && $op eq 'cud-transfer') { # actually return book and prepare item table..... my $returnbranch; -if ($barcode && $op eq 'cud-checkin') { +if ($barcode && ( $op eq 'cud-checkin' || $op eq 'cud-affect_reserve' ) ) { $barcode = barcodedecode($barcode) if $barcode; my $item = Koha::Items->find({ barcode => $barcode });