Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15869: (QA follow-up) Don't pass placeholder framework '_USE_ORIG'

Browse source 
This param in the dropdown is meant to signify no change, distinct from
"" when means to set to default. In rebasing this condition was lost, this patch
restores undef of the variable to avoid setting framework to an invalid value

To test:
1 - Stage a record with a match (export and import a record)
2 - Attempt to import and overlay with option 'When replacing records use this framework:' 'Keep original framework'
3 - It fails, logs note 'value too long for field frameworkcode'
4 - Apply this patch
5 - Try again, it succeeds - framework is not changed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ae4c09ed5e)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
This commit is contained in:
Nick Clemens 2023-01-18 19:53:54 +00:00 committed by Jacob O'Mara
parent 096853d56a
commit 55a1e189bf
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
tools/manage-marc-import.pl
View file

@ -90,6 +90,7 @@ if ($op eq "") {
} elsif ($op eq "commit-batch") {
my $frameworkcode = $input->param('framework');
my $overlay_framework = $input->param('overlay_framework');
$overlay_framework = undef if $overlay_framework = '_USE_ORIG';
try {
my $job_id = Koha::BackgroundJob::MARCImportCommitBatch->new->enqueue(
{