Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21692: (QA follow-up) Enhance test for new

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Martin Renvoize 2019-02-19 19:34:04 +00:00 committed by root
parent 34c36a32a0
commit 569c64252e
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
t/db_dependent/Koha/Account.t
View file

@ -19,7 +19,7 @@
use Modern::Perl; use Modern::Perl;
use Test::More tests => 7; use Test::More tests => 8;
use Test::MockModule; use Test::MockModule;
use Test::Exception; use Test::Exception;
@ -34,6 +34,21 @@ use t::lib::TestBuilder;
my $schema = Koha::Database->new->schema; my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new; my $builder = t::lib::TestBuilder->new;
subtest 'new' => sub {
plan tests => 2;
$schema->storage->txn_begin;
throws_ok { Koha::Account->new(); } qr/No patron id passed in!/, 'Croaked on bad call to new';
my $patron = $builder->build_object({ class => 'Koha::Patrons' });
my $account = Koha::Account->new( { patron_id => $patron->borrowernumber } );
is( defined $account, 1, "Account is defined" );
$schema->storage->txn_rollback;
};
subtest 'outstanding_debits() tests' => sub { subtest 'outstanding_debits() tests' => sub {
plan tests => 22; plan tests => 22;
@ -141,7 +156,7 @@ subtest 'outstanding_credits() tests' => sub {
subtest 'add_credit() tests' => sub { subtest 'add_credit() tests' => sub {
plan tests => 16; plan tests => 15;
$schema->storage->txn_begin; $schema->storage->txn_begin;
@ -151,7 +166,6 @@ subtest 'add_credit() tests' => sub {
my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
my $account = Koha::Account->new( { patron_id => $patron->borrowernumber } ); my $account = Koha::Account->new( { patron_id => $patron->borrowernumber } );
is( defined $account, 1, "Account is defined" );
is( $account->balance, 0, 'Patron has no balance' ); is( $account->balance, 0, 'Patron has no balance' );