Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21597: Field 'description' doesn't have a default value

Browse source 
Nick proposed another fix, see bug 21594.
The interface does not explode so I do not think we should make a DB
update in a rush.

Fix t/db_dependent/Koha/Object.t and t/db_dependent/Koha/ApiKeys.t

api_keys.description and api_keys.secret:
  `secret` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL,
  `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,

    #   Failed test 'Exception is thrown correctly'
    #   at t/db_dependent/Koha/Object.t line 262.
    # expecting: Koha::Exceptions::Object::FKConstraint
    # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Field 'description' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125
    # )
    # Looks like you planned 7 tests but ran 1.
    # Looks like you failed 1 test of 1 run.

and later, but not related:
Can't locate object method "message" via package
"DBIx::Class::Exception" at t/db_dependent/Koha/Object.t line 264.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2018-10-17 19:26:32 -03:00 committed by Nick Clemens
parent 489c636316
commit 573d9dafc1
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
t/db_dependent/Koha/ApiKeys.t
View file

@ -80,7 +80,7 @@ subtest 'store() tests' => sub {
$patron_to_delete->delete;
throws_ok
{ Koha::ApiKey->new({ patron_id => $deleted_id })->store }
{ Koha::ApiKey->new({ patron_id => $deleted_id, description => 'a description' })->store }
'Koha::Exceptions::Object::FKConstraint',
'Invalid patron ID raises exception';
is( $@->message, 'Broken FK constraint', 'Exception message is correct' );

3
t/db_dependent/Koha/Object.t
View file

@ -253,7 +253,7 @@ subtest 'store() tests' => sub {
my $patron_id = $patron->id;
$patron->delete;
my $api_key = Koha::ApiKey->new({ patron_id => $patron_id });
my $api_key = Koha::ApiKey->new({ patron_id => $patron_id, secret => 'a secret', description => 'a description' });
my $print_error = $schema->storage->dbh->{PrintError};
$schema->storage->dbh->{PrintError} = 0;
@ -278,6 +278,7 @@ subtest 'store() tests' => sub {
my $new_api_key = Koha::ApiKey->new({
patron_id => $patron_id,
secret => $api_key->secret,
description => 'a description',
});
throws_ok