Browse Source
This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>20.11.x
Agustin Moyano
18 changed files with 224 additions and 82 deletions
@ -1,25 +1,41 @@ |
|||
[% USE Koha %] |
|||
[% BLOCK add_password_check %] |
|||
<script> |
|||
var pwd_title = ""; |
|||
var pattern_title = ""; |
|||
var new_password_node_name = "[% new_password | html %]"; |
|||
[% IF Koha.Preference('RequireStrongPassword') %] |
|||
pwd_title = _("Password must contain at least %s characters, including UPPERCASE, lowercase and numbers").format([% minPasswordLength | html %]); |
|||
pattern_regex = /(?=.*\d)(?=.*[a-z])(?=.*[A-Z]).{[% minPasswordLength | html %],}/; |
|||
[% ELSIF minPasswordLength %] |
|||
pwd_title = _("Password must contain at least %s characters").format([% minPasswordLength | html %]); |
|||
pattern_regex = /.{[% minPasswordLength | html %],}/; |
|||
[% END %] |
|||
jQuery.validator.addMethod("password_strong", function(value, element){ |
|||
return this.optional(element) || pattern_regex.test(value); |
|||
}, pwd_title); |
|||
var category_selector = "[% category_selector | html %]"; |
|||
var STRONG_MSG = _("Password must contain at least %s characters, including UPPERCASE, lowercase and numbers"); |
|||
var WEAK_MSG = _("Password must contain at least %s characters"); |
|||
|
|||
if(category_selector && $('select'+category_selector).length) { |
|||
jQuery.validator.addMethod("password_strong", function(value, element){ |
|||
var require_strong = $('select'+category_selector+' option:selected').data('pwdStrong'); |
|||
var min_lenght = $('select'+category_selector+' option:selected').data('pwdLength'); |
|||
var regex_text = require_strong?"(?=.*\\d)(?=.*[a-z])(?=.*[A-Z]).{"+min_lenght+",}":".{"+min_lenght+",}"; |
|||
var pattern_regex = new RegExp(regex_text); |
|||
return this.optional(element) || pattern_regex.test(value); |
|||
}, function(unused, element) { |
|||
var require_strong = $('select'+category_selector+' option:selected').data('pwdStrong'); |
|||
var min_lenght = $('select'+category_selector+' option:selected').data('pwdLength'); |
|||
return (require_strong?STRONG_MSG:WEAK_MSG).format(min_lenght) |
|||
}); |
|||
} else { |
|||
[% IF RequireStrongPassword %] |
|||
pwd_title = STRONG_MSG.format([% minPasswordLength | html %]); |
|||
pattern_regex = /(?=.*\d)(?=.*[a-z])(?=.*[A-Z]).{[% minPasswordLength | html %],}/; |
|||
[% ELSIF minPasswordLength %] |
|||
pwd_title = WEAK_MSG.format([% minPasswordLength | html %]); |
|||
pattern_regex = /.{[% minPasswordLength | html %],}/; |
|||
[% END %] |
|||
jQuery.validator.addMethod("password_strong", function(value, element){ |
|||
return this.optional(element) || value == '****' || pattern_regex.test(value); |
|||
}, pwd_title); |
|||
} |
|||
jQuery.validator.addMethod("password_no_spaces", function(value, element){ |
|||
return ( this.optional(element) || !value.match(/^\s/) && !value.match(/\s$/) ); |
|||
}, _("Password contains leading and/or trailing spaces")); |
|||
jQuery.validator.addMethod("password_match", function(value, element){ |
|||
var new_password_node = $("input[name='" + new_password_node_name + "']:first"); |
|||
return this.optional(element) || value == $(new_password_node).val(); |
|||
return value == $(new_password_node).val(); |
|||
}, _("Please enter the same password as above")); |
|||
</script> |
|||
[% END %] |
|||
</script> |
|||
Loading…
Reference in new issue