Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

CleanBorrowers fixing.

Browse source 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This commit is contained in:
Henri-Damien LAURENT 2008-03-19 10:11:12 -05:00 committed by Joshua Ferraro
parent c7054a0247
commit 5904681fac
2 changed files with 103 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

111
C4/Members.pm
View file

@ -58,9 +58,9 @@ BEGIN {
&GetSortDetails
&GetTitles
&GetPatronImage
&PutPatronImage
&RmPatronImage
&GetPatronImage
&PutPatronImage
&RmPatronImage
&GetMemberAccountRecords
&GetBorNotifyAcctRecord
@ -1797,24 +1797,46 @@ WHERE roadtypeid=?|;
&GetBorrowersWhoHaveNotBorrowedSince($date)
this function get all borrowers who haven't borrowed since the date given on input arg.
=cut
sub GetBorrowersWhoHaveNotBorrowedSince {
my $date = shift;
return unless $date; # date is mandatory.
### TODO : It could be dangerous to delete Borrowers who have just been entered and who have not yet borrowed any book. May be good to add a dateexpiry or dateenrolled filter.
my $filterdate = shift||POSIX::strftime("%Y-%m-%d",localtime());
my $filterbranch = shift ||
((C4::Context->preference('IndependantBranches')
&& C4::Context->userenv
&& C4::Context->userenv->{flags}!=1
&& C4::Context->userenv->{branch})
? C4::Context->userenv->{branch}
: "");
my $dbh = C4::Context->dbh;
my $query = "
SELECT borrowers.borrowernumber,max(timestamp)
SELECT borrowers.borrowernumber,max(issues.timestamp) as latestissue
FROM borrowers
LEFT JOIN issues ON borrowers.borrowernumber = issues.borrowernumber
WHERE issues.borrowernumber IS NOT NULL
GROUP BY borrowers.borrowernumber
";
my @query_params;
if ($filterbranch && $filterbranch ne ""){
$query.=" WHERE branchcode= ?";
push @query_params,$filterbranch;
}
$query.=" GROUP BY borrowers.borrowernumber";
if ($filterdate){
$query.=" HAVING latestissue <? OR latestissue IS NULL";
push @query_params,$filterdate;
}
warn $query;
my $sth = $dbh->prepare($query);
$sth->execute;
if (scalar(@query_params)>0){
$sth->execute(@query_params);
}
else {
$sth->execute;
}
my @results;
while ( my $data = $sth->fetchrow_hashref ) {
push @results, $data;
}
@ -1832,15 +1854,35 @@ I<$result> is a ref to an array which all elements are a hasref.
=cut
sub GetBorrowersWhoHaveNeverBorrowed {
my $filterbranch = shift ||
((C4::Context->preference('IndependantBranches')
&& C4::Context->userenv
&& C4::Context->userenv->{flags}!=1
&& C4::Context->userenv->{branch})
? C4::Context->userenv->{branch}
: "");
my $dbh = C4::Context->dbh;
my $query = "
SELECT borrowers.borrowernumber,max(timestamp)
SELECT borrowers.borrowernumber,max(timestamp) as latestissue
FROM borrowers
LEFT JOIN issues ON borrowers.borrowernumber = issues.borrowernumber
WHERE issues.borrowernumber IS NULL
";
my @query_params;
if ($filterbranch && $filterbranch ne ""){
$query.=" AND branchcode= ?";
push @query_params,$filterbranch;
}
warn $query;
my $sth = $dbh->prepare($query);
$sth->execute;
if (scalar(@query_params)>0){
$sth->execute(@query_params);
}
else {
$sth->execute;
}
my @results;
while ( my $data = $sth->fetchrow_hashref ) {
push @results, $data;
@ -1861,15 +1903,25 @@ This hashref is containt the number of time this borrowers has borrowed before I
sub GetBorrowersWithIssuesHistoryOlderThan {
my $dbh = C4::Context->dbh;
my $date = shift;
return unless $date; # date is mandatory.
my $date = shift ||POSIX::strftime("%Y-%m-%d",localtime());
my $filterbranch = shift ||
((C4::Context->preference('IndependantBranches')
&& C4::Context->userenv
&& C4::Context->userenv->{flags}!=1
&& C4::Context->userenv->{branch})
? C4::Context->userenv->{branch}
: "");
my $query = "
SELECT count(borrowernumber) as n,borrowernumber
FROM old_issues
WHERE returndate < ?
AND borrowernumber IS NOT NULL
GROUP BY borrowernumber
";
";
if ($filterbranch){
$query.=" AND branchcode=\'$filterbranch\'";
}
$query.=" GROUP BY borrowernumber ";
warn $query;
my $sth = $dbh->prepare($query);
$sth->execute($date);
my @results;
@ -1880,6 +1932,31 @@ sub GetBorrowersWithIssuesHistoryOlderThan {
return \@results;
}
=head2 GetBorrowersNamesAndLatestIssue
$results = &GetBorrowersNamesAndLatestIssueList(@borrowernumbers)
this function get borrowers Names and surnames and Issue information.
I<@borrowernumbers> is an array which all elements are borrowernumbers.
This hashref is containt the number of time this borrowers has borrowed before I<$date> and the borrowernumber.
=cut
sub GetBorrowersNamesAndLatestIssue {
my $dbh = C4::Context->dbh;
my @borrowernumbers=@_;
my $query = "
SELECT surname,lastname, phone, email,max(timestamp)
FROM borrowers
LEFT JOIN issues ON borrowers.borrowernumber=issues.borrowernumber
GROUP BY borrowernumber
";
my $sth = $dbh->prepare($query);
$sth->execute;
my $results = $sth->fetchall_arrayref({});
return $results;
}
END { } # module clean-up code here (global destructor)
1;

13
tools/cleanborrowers.pl
View file

@ -69,14 +69,16 @@ if ( $params->{'step2'} ) {
my $checkbox = $params->{'checkbox'};
my $totalDel;
my $membersToDelete;
if ($checkbox eq "borrower") {
my $membersToDelete = GetBorrowersWhoHaveNotBorrowedSince($filterdate1);
$membersToDelete = GetBorrowersWhoHaveNotBorrowedSince($filterdate1);
$totalDel = scalar @$membersToDelete;
}
my $totalAno;
my $membersToAnonymize;
if ($checkbox eq "issue") {
my $membersToAnonymize =
$membersToAnonymize =
GetBorrowersWithIssuesHistoryOlderThan($filterdate2);
$totalAno = scalar @$membersToAnonymize;
}
@ -85,10 +87,13 @@ if ( $params->{'step2'} ) {
step2 => 1,
totalToDelete => $totalDel,
totalToAnonymize => $totalAno,
memberstodelete_list => $membersToDelete,
memberstoanonymize_list => $membersToAnonymize,
filterdate1 => format_date($filterdate1),
filterdate2 => format_date($filterdate2),
);
### TODO : Use GetBorrowersNamesAndLatestIssue function in order to get the borrowers to delete or anonymize.
### Now, we are only using total, which is not enough imlo
#writing the template
output_html_with_http_headers $cgi, $cookie, $template->output;
exit;