Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12706: Remove CGI::scrolling_list from serial_stats.pl

Browse source 
This patch depends on Bug 12696

Removed one instance in this file.
Pulldown with one value, 'CSV'

To test:
1. Apply the patch for Bug 12696
2. Apply this patch
3. Go to Reports > Statistics wizard > Serial
4. Check 'Into an application' pulldown, with value 'CSV'
5. Search for regressions

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script, works as described.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Bernardo Gonzalez Kriegel 2014-08-03 16:08:38 -03:00 committed by Tomas Cohen Arazi
parent 52172938c2
commit 5a9786eea8
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt
View file

@ -121,7 +121,11 @@
<label for="outputfile">To a file:</label> <input type="radio" name="output" value="file" id="outputfile" /> <label for="outputfile">To a file:</label> <input type="radio" name="output" value="file" id="outputfile" />
<label class="inline" for="basename">Named: </label><input type="text" name="basename" id="basename" value="Export" /> <label class="inline" for="basename">Named: </label><input type="text" name="basename" id="basename" value="Export" />
<label class="inline" for="MIME">Into an application</label> <label class="inline" for="MIME">Into an application</label>
[% CGIextChoice %] <select name="MIME" id="MIME" size="1">
[% FOREACH value IN CGIextChoice %]
<option value="[% value %]">[% value %]</option>
[% END %]
</select>
<select name="sep" id="sep" size="1"> <select name="sep" id="sep" size="1">
[% FOREACH value IN CGIsepChoice.values.sort() %] [% FOREACH value IN CGIsepChoice.values.sort() %]
[% IF ( value == CGIsepChoice.default ) %] [% IF ( value == CGIsepChoice.default ) %]

7
reports/serials_stats.pl
View file

@ -150,12 +150,7 @@ if($do_it){
push(@booksellers,$row) push(@booksellers,$row)
} }
my $CGIextChoice=CGI::scrolling_list( my $CGIextChoice = ( 'CSV' ); # FIXME translation
-name => 'MIME',
-id => 'MIME',
-values => ['CSV'], # FIXME translation
-size => 1,
-multiple => 0 );
my $CGIsepChoice=GetDelimiterChoices; my $CGIsepChoice=GetDelimiterChoices;
$template->param( $template->param(
CGIextChoice => $CGIextChoice, CGIextChoice => $CGIextChoice,