Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12264: [QA Follow-up] Fixing biblionumber/biblioitemnumber mixup

Browse source 
While testing the string change on 12264, I had this result:
DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191.
DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191.
    # Child (GetItemsInfo tests) exited without calling finalize()
not ok 4 - GetItemsInfo tests

This was caused by this line in the unit test:
 my $biblionumber = get_biblio();
This routine returns:
    return ($bibnum, $bibitemnum);
So instead of the bibnum the bibitemnum is saved in biblionumber.
In my test database bibnum and bibitemnum somehow got out of sync, revealing
this bug :)
The fix is just adding parentheses:
 my ( $biblionumber ) = get_biblio();

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Marcel de Rooy 2014-11-10 09:21:46 +01:00 committed by Tomas Cohen Arazi
parent 3740b2684c
commit 5b0b78c316
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
t/db_dependent/Items.t
View file

@ -165,7 +165,7 @@ subtest 'GetItemsInfo tests' => sub {
my $holdingbranch = 'MPL';
# Add a biblio
my $biblionumber = get_biblio();
my ($biblionumber) = get_biblio();
# Add an item
my ($item_bibnum, $item_bibitemnum, $itemnumber)
= AddItem({