Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25417: (QA follow-up) Add integration test for AddReturn

Browse source 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Martin Renvoize 2020-05-12 09:24:28 +01:00
parent 7b84e00f7e
commit 5bff65dd7a
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 45 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
t/db_dependent/Circulation.t
View file

@ -2337,7 +2337,7 @@ subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
subtest 'AddReturn | is_overdue' => sub {
plan tests => 5;
plan tests => 6;
t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment');
t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
@ -2432,7 +2432,49 @@ subtest 'AddReturn | is_overdue' => sub {
AddReturn( $item->{barcode}, $library->{branchcode} );
is( int( $patron->account->balance() ),
17, "Should have a single 10 days overdue fine and lost charge" );
}
# Cleanup
Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
};
subtest 'bug 25417 | backdated return + exemptfine' => sub {
plan tests => 6;
t::lib::Mocks::mock_preference('CalculateFinesOnBackdate', 1);
my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $one_day_ago ); # date due was 1d ago
# Fake fines cronjob on this checkout
my ($fine) =
CalcFine( $item, $patron->categorycode, $library->{branchcode},
$one_day_ago, $now );
UpdateFine(
{
issue_id => $issue->issue_id,
itemnumber => $item->{itemnumber},
borrowernumber => $patron->borrowernumber,
amount => $fine,
due => output_pref($one_day_ago)
}
);
is( int( $patron->account->balance() ),
1, "Overdue fine of 1 day overdue" );
# Backdated return (dropbox mode example - charge should exist but be zero)
AddReturn( $item->{barcode}, $library->{branchcode}, 1, $one_day_ago );
is( int( $patron->account->balance() ),
0, "Overdue fine should be annulled" );
my $lines = Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber });
is( $lines->count, 1, "Overdue fine accountlines still exists");
my $line = $lines->next;
is($line->amount+0,0, "Overdue fine amount has been reduced to 0");
is($line->amountoutstanding+0,0, "Overdue fine amount outstanding has been reduced to 0");
is($line->status,'RETURNED', "Overdue fine was fixed");
# Cleanup
Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
};
};
subtest '_FixAccountForLostAndFound' => sub {
@ -2892,7 +2934,7 @@ subtest '_FixOverduesOnReturn' => sub {
is( $credit->amount + 0, -99, "Credit amount is set correctly" );
is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
# Bug 25417 - Only forgive fines where there is an amount oustanding to forgive
# Bug 25417 - Only forgive fines where there is an amount outstanding to forgive
$accountline->set(
{
debit_type_code => 'OVERDUE',