Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21105: (QA follow-up) Silence warning because of tests setup

Browse source 
The tests are using 'http://localhost' and the regex is setting $baseURL
to empty in this case. It works on the oai.pl front-end.

This patch changes the regex.

To test:
1. Run:
   $ kshell
  k$ t/db_dependent/OAI/Server.t
=> FAIL: Boo! Warning!
2. Apply this patch
3. Repeat 2
=> SUCCESS: Oh, cool. No warning :-D
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomás Cohen Arazi 2021-11-12 11:15:08 -03:00 committed by Jonathan Druart
parent 24c2fee5b4
commit 5cce101444
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Koha/OAI/Server/Identify.pm
View file

@ -28,7 +28,10 @@ use base ("HTTP::OAI::Identify");
sub new {
my ($class, $repository) = @_;
my ($baseURL) = $repository->self_url() =~ /(.*)\?.*/;
my $baseURL = $repository->self_url();
$baseURL = $+{base_url}
if $baseURL =~ m/(?<base_url>.*)\?.*/;
my $self = $class->SUPER::new(
baseURL => $baseURL,
repositoryName => C4::Context->preference("LibraryName"),