Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30432: Unit test

Browse source 
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Nick Clemens 2022-04-01 12:48:27 +00:00 committed by Fridolin Somers
parent a41117032c
commit 5d53081cb8
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
t/db_dependent/Koha/Holds.t
View file

@ -411,7 +411,7 @@ subtest 'Desks' => sub {
};
subtest 'get_items_that_can_fill' => sub {
plan tests => 5;
plan tests => 6;
my $biblio = $builder->build_sample_biblio;
my $itype_1 = $builder->build_object({ class => 'Koha::ItemTypes' }); # For 1, 2, 3, 4
@ -503,6 +503,19 @@ subtest 'get_items_that_can_fill' => sub {
is_deeply( [ map { $_->itemnumber } $items->as_list ],
[ $item_2->itemnumber ], 'Only item 2 is available for filling the hold' );
my $noloan_itype = $builder->build_object( { class => 'Koha::ItemTypes', value => { notforloan => 1 } } );
t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
Koha::Holds->find( $waiting_reserve_id )->delete;
$holds = Koha::Holds->search(
{
reserve_id => [ $reserve_id_1, $reserve_id_2 ]
}
);
$items = $holds->get_items_that_can_fill;
is_deeply( [ map { $_->itemnumber } $items->as_list ],
[ $item_1->itemnumber, $item_2->itemnumber, $item_5->itemnumber ], 'Items 1, 2, and 5 are available for filling the holds' );
my $no_holds = Koha::Holds->new->empty();
my $no_items = $no_holds->get_items_that_can_fill();
is( ref $no_items, "Koha::Items", "Routine returns a Koha::Items object");