From 5d9348ffa22ecf8cf2a2cf2f953d4e18930c2669 Mon Sep 17 00:00:00 2001 From: Charlotte Cordwell Date: Thu, 18 Jan 2018 02:58:06 +0000 Subject: [PATCH] Bug 20012: use Modern::Perl in Reports perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; borrowers_out.pl cat_issues_top.pl catalogue_out.pl catalogue_stats.pl dictionary.pl issues_avg_stats.pl issues_stats.pl itemslost.pl manager.pl reports-home.pl serials_stats.pl stats.print.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- reports/borrowers_out.pl | 3 +-- reports/cat_issues_top.pl | 3 +-- reports/catalogue_out.pl | 3 +-- reports/catalogue_stats.pl | 3 +-- reports/dictionary.pl | 3 +-- reports/issues_avg_stats.pl | 3 +-- reports/issues_stats.pl | 3 +-- reports/itemslost.pl | 3 +-- reports/manager.pl | 3 +-- reports/reports-home.pl | 3 +-- reports/serials_stats.pl | 3 +-- reports/stats.print.pl | 3 +-- 12 files changed, 12 insertions(+), 24 deletions(-) diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl index 50c73b0dcb..762a0d4d09 100755 --- a/reports/borrowers_out.pl +++ b/reports/borrowers_out.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl index 958a72e059..e7a315f588 100755 --- a/reports/cat_issues_top.pl +++ b/reports/cat_issues_top.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use C4::Auth; use CGI qw ( -utf8 ); use C4::Context; diff --git a/reports/catalogue_out.pl b/reports/catalogue_out.pl index 0c53a79178..3b0fdd8f74 100755 --- a/reports/catalogue_out.pl +++ b/reports/catalogue_out.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl index dcd28894c0..b7bd98a024 100755 --- a/reports/catalogue_stats.pl +++ b/reports/catalogue_stats.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use C4::Auth; use CGI qw ( -utf8 ); use C4::Context; diff --git a/reports/dictionary.pl b/reports/dictionary.pl index 7d86f8d11a..bca95ce0bd 100755 --- a/reports/dictionary.pl +++ b/reports/dictionary.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . use CGI::Carp qw(fatalsToBrowser warningsToBrowser); -use strict; -use warnings; +use Modern::Perl; use C4::Auth; use CGI qw ( -utf8 ); use C4::Output; diff --git a/reports/issues_avg_stats.pl b/reports/issues_avg_stats.pl index 5c35de781e..cea969e5b0 100755 --- a/reports/issues_avg_stats.pl +++ b/reports/issues_avg_stats.pl @@ -18,8 +18,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use C4::Auth; use CGI qw ( -utf8 ); use C4::Context; diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl index 75c54baac6..2da53d86ce 100755 --- a/reports/issues_stats.pl +++ b/reports/issues_stats.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use Date::Manip; diff --git a/reports/itemslost.pl b/reports/itemslost.pl index 75bb067c77..6ca5a78d88 100755 --- a/reports/itemslost.pl +++ b/reports/itemslost.pl @@ -25,8 +25,7 @@ This script displays lost items. =cut -use strict; -use warnings; +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; diff --git a/reports/manager.pl b/reports/manager.pl index e9ec30e16d..2ff27e8283 100755 --- a/reports/manager.pl +++ b/reports/manager.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; use C4::Context; diff --git a/reports/reports-home.pl b/reports/reports-home.pl index c1e92c2119..6bcc996466 100755 --- a/reports/reports-home.pl +++ b/reports/reports-home.pl @@ -18,8 +18,7 @@ # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Auth; use C4::Output; diff --git a/reports/serials_stats.pl b/reports/serials_stats.pl index 614b95f4ca..0c5ed28331 100755 --- a/reports/serials_stats.pl +++ b/reports/serials_stats.pl @@ -17,8 +17,7 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; use C4::Auth; use CGI qw ( -utf8 ); use C4::Context; diff --git a/reports/stats.print.pl b/reports/stats.print.pl index 9495360342..5763969609 100755 --- a/reports/stats.print.pl +++ b/reports/stats.print.pl @@ -1,7 +1,6 @@ #!/usr/bin/perl -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Output;