Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34300: (QA follow-up) Add permission check and fix missing table cells

Browse source 
* Changes text from "Place a hold on order" to the more common "Place hold"
* Adds permission check on reserveforothers.
* We were missing table cells in the footer rows of the table.

I would have liked to hide the column for someone missing permissions,
but I failed to get the datatable configuration right with the export
and column configuration settings.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Katrin Fischer 2023-10-09 21:29:13 +00:00 committed by Tomas Cohen Arazi
parent 01602b59d5
commit 5db28348ea
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
View file

@ -482,7 +482,7 @@
[% IF Koha.Preference('EDIFACT') && ediaccount %]
<th>Supplier report</th>
[% END %]
<th>Place hold</th>
<th class="NoSort">Place hold</th>
[% IF ( active ) %]
[% UNLESS ( closedate ) %]
<th class="NoSort">Modify</th>
@ -516,6 +516,7 @@
[% IF Koha.Preference('EDIFACT') && ediaccount %]
<th>&nbsp;</th>
[% END %]
<th>&nbsp;</th>
[% IF ( active ) %]
[% UNLESS ( closedate ) %]
<th>&nbsp;</th>
@ -547,6 +548,7 @@
[% IF Koha.Preference('EDIFACT') && ediaccount %]
<th>&nbsp;</th>
[% END %]
<th>&nbsp;</th>
[% IF ( active ) %]
[% UNLESS ( closedate ) %]
<th>&nbsp;</th>
@ -678,9 +680,11 @@
<td>[% books_loo.suppliers_report | html %]</td>
[% END %]
<td>
<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% books_loo.biblionumber | uri %]">
Place a hold on the order
</a>
[% IF ( CAN_user_reserveforothers_place_holds ) %]
<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% books_loo.biblionumber | uri %]">
Place hold
</a>
[% END %]
</td>
[% IF ( active ) %]
[% UNLESS ( closedate ) %]