Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35469: Add 'manage_bookings' permission to biblios/checkouts

Browse source 
This patch adds the manage_bookings subpermission check to the
biblios/{biblio_id}/checkouts endpoint and updates the corresponding
unit test too.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Martin Renvoize 2023-12-19 13:30:14 +00:00 committed by Katrin Fischer
parent 30b3a8c382
commit 5e0afb772a
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 39 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
api/v1/swagger/paths/biblios.yaml
View file

@ -403,7 +403,8 @@
$ref: "../swagger.yaml#/definitions/error"
x-koha-authorization:
permissions:
circulate: circulate_remaining_permissions
- circulate: circulate_remaining_permissions
- circulate: manage_bookings
"/biblios/{biblio_id}/items":
get:
x-mojo-to: Biblios#get_items

42
t/db_dependent/api/v1/biblios.t
View file

@ -726,7 +726,7 @@ subtest 'get_bookings() tests' => sub {
subtest 'get_checkouts() tests' => sub {
plan tests => 14;
plan tests => 17;
$schema->storage->txn_begin;
@ -745,11 +745,43 @@ subtest 'get_checkouts() tests' => sub {
$t->get_ok("//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts")
->status_is(403);
$patron->flags(1)->store; # circulate permissions
$builder->build(
{
source => 'UserPermission',
value => {
borrowernumber => $patron->borrowernumber,
module_bit => 1,
code => 'circulate_remaining_permissions',
},
}
);
$t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts")
->status_is(200)
->json_is( '' => [], 'No checkouts on the biblio' );
$t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts" )
->status_is( 200, 'circulate_remaining_permissions allows checkouts access' )
->json_is( '' => [], 'No checkouts on the biblio' );
my $bookings_librarian = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 0 } # no additional permissions
}
);
$builder->build(
{
source => 'UserPermission',
value => {
borrowernumber => $bookings_librarian->borrowernumber,
module_bit => 1,
code => 'manage_bookings',
},
}
);
$bookings_librarian->set_password( { password => $password, skip_validation => 1 } );
my $bookings_userid = $bookings_librarian->userid;
$t->get_ok( "//$bookings_userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts" )
->status_is( 200, 'manage_bookings allows checkouts access' )
->json_is( '' => [], 'No checkouts on the biblio' );
my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });