Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 11603: If a letter code is given, filenames should contain it

Browse source 
If you choose to generate print notices for a specific letter code, the
generated files should be distinct.

The use case is: you want to process print notice for letter codes:
overdue1, overdue2 and overdue3.

The cronjobs will be:

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue1 --csv --ods --html --delimiter=";"

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue2 --csv --ods --html --delimiter=";"

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue3 --csv --ods --html --delimiter=";"

without this patch, the 2 first files will be erased.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2014-02-26 13:35:42 +01:00 committed by Tomas Cohen Arazi
parent 9234b66038
commit 5e4633a3cc
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
misc/cronjobs/gather_print_notices.pl
View file

@ -134,10 +134,10 @@ sub print_notices {
}
while ( my ( $branchcode, $branch_messages ) = each %$messages_by_branch ) {
my $letter_code = @letter_codes == 1 ? $letter_codes[0] : 'hold';
my $filename = $split
? 'holdnotices-' . $today->output('iso') . "-$branchcode.$format"
: 'holdnotices-' . $today->output('iso') . ".$format";
? "notices_$letter_code-" . $today->output('iso') . "-$branchcode.$format"
: "notices_$letter_code-" . $today->output('iso') . ".$format";
my $filepath = File::Spec->catdir( $output_directory, $filename );
if ( $format eq 'html' ) {
generate_html({