Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31086: (QA follow-up) Improve atomicupdate to be more resilient

Browse source 
We now populate the branchcode field with the first available branch on
the system if we find it to be NULL before we set the NOT NULL

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Martin Renvoize 2022-07-22 10:05:55 +01:00 committed by Tomas Cohen Arazi
parent f0685f0f40
commit 5fa510b431
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
installer/data/mysql/atomicupdate/bug_31086_do_not_allow_null_branchcode_in_reserves.pl
View file

@ -6,10 +6,18 @@ return {
up => sub {
my ($args) = @_;
my ($dbh, $out) = @$args{qw(dbh out)};
# Ensure we have no NULL's in the branchcode field
$dbh->do(q{
UPDATE reserves SET branchcode = ( SELECT branchcode FROM branches LIMIT 1) WHERE branchode IS NULL;
});
# Set the NOT NULL configuration
$dbh->do(q{
ALTER TABLE reserves
MODIFY COLUMN `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at'
});
# Print useful stuff here
say $out "Removed NULL option from branchcode for reserves";
},