Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl

Browse source 
GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work.

Also fixes a typo.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This commit is contained in:
Mirko Tietgen 2012-07-11 13:08:10 +02:00 committed by Paul Poulain
parent 6c77b4d117
commit 608402e27b
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
misc/load_testing/benchmark_staff.pl
View file

@ -18,6 +18,7 @@ use Data::Dumper;
use HTTP::Cookies;
use C4::Context;
use C4::Debug;
use URI::Escape;
my ($help, $steps, $baseurl, $max_tries, $user, $password,$short_print);
GetOptions(
@ -241,7 +242,7 @@ if ($steps=~ /4/) {
my $b2 = HTTPD::Bench::ApacheBench->new;
$b2->concurrency( $concurrency );
unless ($short_print) {
print "Step 5: patron detail page ";
print "Step 4: patron detail page ";
}
my $run2 = HTTPD::Bench::ApacheBench::Run->new
({ urls => \@borrowers,
@ -324,7 +325,7 @@ if ($steps=~ /6/) {
until ($rand_barcode) {
my $rand_itemnumber = int(rand($itemnumber_max)+1);
$sth->execute($rand_itemnumber);
($rand_barcode) = $sth->fetchrow();
($rand_barcode) = uri_escape_utf8($sth->fetchrow());
}
push @issues,"$baseurl/circ/circulation.pl?borrowernumber=$rand_borrowernumber&barcode=$rand_barcode&issueconfirmed=1";
push @returns,"$baseurl/circ/returns.pl?barcode=$rand_barcode";