From 60ba1bf5dd26b75d86f31325183eea4359702f84 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 29 Dec 2016 11:32:27 -0300 Subject: [PATCH] Bug 17825: Remove the use of AttributeTypeExists from opac-user.pl With the introducion of Koha::Object-based Koha::Patron::Attribute::Type(s) there's no need for using this function. This patch replaces it with a regular ->search + ->count call. To test: - Have a user with checkouts logged into the OPAC on the opac-user.pl page - Set the SHOW_BCODE attribute to 'no' on the staff interface for the user. - Reload opac-user.pl => SUCCESS: The barcode is not shown for checked out items. - Set the SHOW_BCODE atttribute to 'yes' on the staff interface for the user. - Reload opac-user.pl => SUCCESS: The barcode is shown for checked out items. - Delete the Patron attribute type SHOW_BCODE - Reload opac-user.pl => SUCCESS: No barcode is shown for checked out items - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- opac/opac-user.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/opac/opac-user.pl b/opac/opac-user.pl index 905d52c343..9a041743a5 100755 --- a/opac/opac-user.pl +++ b/opac/opac-user.pl @@ -36,6 +36,7 @@ use C4::Letters; use Koha::DateUtils; use Koha::Holds; use Koha::Database; +use Koha::Patron::Attribute::Types; use Koha::Patron::Messages; use Koha::Patron::Discharge; use Koha::Patrons; @@ -268,7 +269,8 @@ $template->param( canrenew => $canrenew ); $template->param( OVERDUES => \@overdues ); $template->param( overdues_count => $overdues_count ); -my $show_barcode = C4::Members::AttributeTypes::AttributeTypeExists( ATTRIBUTE_SHOW_BARCODE ); +my $show_barcode = Koha::Patron::Attribute::Types->search( + { code => ATTRIBUTE_SHOW_BARCODE } )->count; if ($show_barcode) { my $patron_show_barcode = GetBorrowerAttributeValue($borrowernumber, ATTRIBUTE_SHOW_BARCODE); undef $show_barcode if defined($patron_show_barcode) && !$patron_show_barcode;