Bug 33130: Use template wrapper for breadcrumbs: Authorities

This patch updates several administration templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Authorities home page
  - Authority search results
  - Authority detail
  - Authority add/edit
  - Authority merge

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-03-01 20:06:31 +00:00 committed by Tomas Cohen Arazi
parent 6faf64eb3b
commit 61114e032f
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
5 changed files with 51 additions and 87 deletions

View file

@ -1,3 +1,4 @@
[% USE raw %]
[% SET footerjs = 1 %] [% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %] [% INCLUDE 'doc-head-open.inc' %]
<title>Authorities &rsaquo; Koha</title> <title>Authorities &rsaquo; Koha</title>
@ -10,18 +11,11 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item bc_active= 1 %]
<li> <span>Authorities</span>
<a href="/cgi-bin/koha/mainpage.pl">Home</a> [% END %]
</li> [% END %]
<li>
<a href="#" aria-current="page">
Authorities
</a>
</li>
</ol>
</nav>
[% END %] [% END %]
<div class="main container-fluid"> <div class="main container-fluid">

View file

@ -262,34 +262,25 @@
[% INCLUDE 'header.inc' %] [% INCLUDE 'header.inc' %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li> <a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a>
<a href="/cgi-bin/koha/mainpage.pl">Home</a> [% END %]
</li>
<li>
<a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a>
</li>
[% IF ( authid ) %]
<li>
<a href="#" aria-current="page">
Modify authority #[% authid | html %] ([% authtypetext | html %])
</a>
</li>
[% ELSE %]
<li>
<a href="#" aria-current="page">
Adding authority [% authtypetext | html %]
</a>
</li>
[% IF ( authid ) %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
Modify authority #[% authid | html %] ([% authtypetext | html %])
[% END %] [% END %]
</ol>
</nav> <!-- /#breadcrumbs --> [% ELSE %]
[% END %] [% WRAPPER breadcrumb_item bc_active= 1 %]
Adding authority [% authtypetext | html %]
[% END %]
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

View file

@ -23,27 +23,20 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a> <a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page"> [% IF ( unknownauthid ) %]
[% IF ( unknownauthid ) %] <span>Unknown authority record</span>
Unknown authority record [% ELSE %]
[% ELSE %] <span>Details for authority #[% authid | html %] ([% authtypetext | html %])</span>
Details for authority #[% authid | html %] ([% authtypetext | html %]) [% END %]
[% END %] [% END %]
</a> [% END #/ WRAPPER breadcrumbs %]
</li> [% END #/ WRAPPER sub-header.inc %]
</ol>
</nav>
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

View file

@ -18,22 +18,15 @@ div#result { margin-top: 1em; }
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a> <a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page"> <span>Merging records</span>
Merging records [% END %]
</a> [% END #/ WRAPPER breadcrumbs %]
</li> [% END #/ WRAPPER sub-header.inc %]
</ol>
</nav>
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">

View file

@ -24,22 +24,15 @@
[% END %] [% END %]
[% WRAPPER 'sub-header.inc' %] [% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> [% WRAPPER breadcrumbs %]
<ol> [% WRAPPER breadcrumb_item %]
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a> <a href="/cgi-bin/koha/authorities/authorities-home.pl">Authorities</a>
</li> [% END %]
<li> [% WRAPPER breadcrumb_item bc_active= 1 %]
<a href="#" aria-current="page"> <span>Authority search results</span>
Authority search results [% END %]
</a> [% END #/ WRAPPER breadcrumbs %]
</li> [% END #/ WRAPPER sub-header.inc %]
</ol>
</nav>
[% END %]
<div class="main container-fluid"> <div class="main container-fluid">
<div class="row"> <div class="row">