Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32769: Standardize structure around action fieldsets in administration

Browse source 
This patch updates administration templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
the forms look correct:

- Administration
   -> Keyboard shortcuts
   -> Audio alerts
   -> Share content with Mana KB
      - When the ManaToken system preference is empty, the page should
        have two forms with updated fieldsets: the form with the "Use
        Mana KB..." field and a "Configure Mana KB" form.
      - With a ManaToken defined the second form should be one labeled
        "Mana KB token."
   -> Budgets
      - Click on a budget which has existing funds.
      - In the page toolbar click Planning -> Plan by libraries.
      - Check the forms in the sidebar.
   -> System preferences ->  OverDriveAuthName
      - Follow the link to "OverDrive library authnames table" and check
        the form on that page.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-01-31 18:29:01 +00:00 committed by Tomas Cohen Arazi
parent d25b7459b4
commit 622581e5bf
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
5 changed files with 30 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/admin/adveditorshortcuts.tt
View file

@ -64,7 +64,7 @@
[% END %]
</table>
</fieldset>
</fieldset class="action"><input type="submit" class="btn btn-primary" value="Save shortcuts"></fieldset>
<fieldset class="action"><input type="submit" class="btn btn-primary" value="Save shortcuts"></fieldset>
</form>
[% ELSE %]
<p>Enable the advanced cataloging editor ( EnableAdvancedCatalogingEditor system preference) to define keyboard shortcuts</p>

14
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt
View file

@ -252,10 +252,10 @@
<label for="show_actual">Show actual/estimated values</label>
</li>
</ol>
<fieldset class="action">
<input type="submit" name="option_submit" class="btn btn-primary" value="Submit" />
<input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" />
</fieldset>
</fieldset>
<fieldset class="action">
<input type="submit" name="option_submit" class="btn btn-primary" value="Submit" />
<input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" />
</fieldset>
</form>
[% IF ( budget_lines ) %]
@ -277,13 +277,13 @@
</select>
</li>
</ol>
<input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" />
<input type="hidden" name="authcat" value="[% authcat | html %]" />
</fieldset>
<fieldset class="action"> <input type="submit" class="btn btn-primary" value="Submit" />
<input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" />
<input type="hidden" name="report_name" value="[% report_name | html %]" />
<input type="hidden" name="output" value="file" /></fieldset>
<input type="hidden" name="budget_period_id" value="[% budget_period_id | html %]" />
<input type="hidden" name="authcat" value="[% authcat | html %]" />
</fieldset>
</form>
[% END %]

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
View file

@ -145,9 +145,9 @@
</table>
</div> <!-- /.page-section -->
<p>
<fieldset class="action">
<button id="delete-alerts" type="submit" class="btn btn-default disabled"><i class="fa fa-trash"></i> Delete selected alerts</button>
</p>
</fieldset>
</form>
</main>
</div> <!-- /.col-sm-10.col-sm-push-2 -->

17
koha-tmpl/intranet-tmpl/prog/en/modules/admin/overdrive.tt
View file

@ -37,10 +37,9 @@
<h1>OverDrive library authnames</h1>
<div class="page-section">
<form action="/cgi-bin/koha/admin/overdrive.pl" name="overdrive_form" method="post" class="validated">
<input type="hidden" name="op" value="update" />
<form action="/cgi-bin/koha/admin/overdrive.pl" name="overdrive_form" method="post" class="validated">
<input type="hidden" name="op" value="update" />
<fieldset>
<table id="od_info">
<thead>
<tr>
@ -62,11 +61,11 @@
[% END %]
</tbody>
</table>
<div class="action">
<input type="submit" class="btn btn-primary" value="Submit" />
</div>
</form>
</div> <!-- /.page-section -->
</fieldset>
<div class="action">
<input type="submit" class="btn btn-primary" value="Submit" />
</div>
</form>
</main>
</div> <!-- /.col-sm-10.col-sm-push-2 -->

24
koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt
View file

@ -103,10 +103,10 @@
<span class="hint">If checked, new subscriptions you create will be automatically shared with Mana KB.</span>
</li>
</ol>
<fieldset class="action">
<input type="hidden" name="op" value="save" />
<input type="submit" class="btn btn-primary" value="Save" />
</fieldset>
</fieldset>
<fieldset class="action">
<input type="hidden" name="op" value="save" />
<input type="submit" class="btn btn-primary" value="Save" />
</fieldset>
</form>
@ -127,10 +127,10 @@
<div class="hint">Your unique security token used for authentication on Mana KB service (anti spam).</div>
</li>
</ol>
<fieldset class="action">
<input type="hidden" name="op" value="reset" />
<input type="submit" class="btn btn-primary" value="Reset your token" />
</fieldset>
</fieldset>
<fieldset class="action">
<input type="hidden" name="op" value="reset" />
<input type="submit" class="btn btn-primary" value="Reset your token" />
</fieldset>
</form>
[% ELSE %]
@ -147,10 +147,10 @@
<input id="email" type="text" name="email" size="45" required="required" />
</li>
</ol>
<fieldset class="action">
<input type="hidden" name="op" value="send" />
<input type="submit" class="btn btn-primary" value="Send to Mana KB" />
</fieldset>
</fieldset>
<fieldset class="action">
<input type="hidden" name="op" value="send" />
<input type="submit" class="btn btn-primary" value="Send to Mana KB" />
</fieldset>
</form>
[% END %]