Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34968: Remove unneeded module from Search.t

Browse source 
Test::DBIx::Class is not even used here.
Just like C4::Biblio.
We should remove TestBuilder too (this is t not t/db)!

Test plan:
Run t/Search.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 23a8497123)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 6c4eeb1c4a)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2023-09-30 06:40:50 +00:00 committed by Matt Blenkinsop
parent f0afa096e4
commit 631eadb2a5
1 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
t/Search.t
View file

@ -17,29 +17,12 @@
use Modern::Perl;
use C4::Biblio;
use Test::More;
use Test::More tests => 2;
use Test::MockModule;
use Test::Warn;
use t::lib::Mocks;
use t::lib::TestBuilder;
use Module::Load::Conditional qw/check_install/;
BEGIN {
if ( check_install( module => 'Test::DBIx::Class' ) ) {
plan tests => 4;
} else {
plan skip_all => "Need Test::DBIx::Class"
}
}
# Mock the DB connexion and C4::Context
use Test::DBIx::Class;
use_ok('C4::Search');
can_ok('C4::Search',
qw/_build_initial_query/);
use C4::Search;
subtest "_build_initial_query tests" => sub {
@ -187,8 +170,6 @@ subtest "searchResults PassItemMarcToXSLT test" => sub {
return;
});
my $builder = t::lib::TestBuilder->new;
my $xml_record = q{
<record
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"