Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

fix XHTML validation errors in addbiblio.pl

Browse source 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This commit is contained in:
Galen Charlton 2008-02-11 16:21:55 -06:00 committed by Joshua Ferraro
parent 995967117d
commit 6412604238
1 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
cataloguing/addbiblio.pl
View file

@ -301,9 +301,15 @@ sub create_input {
$value =~ s/DD/$day/g; $value =~ s/DD/$day/g;
} }
my $dbh = C4::Context->dbh; my $dbh = C4::Context->dbh;
# map '@' as "subfield" label for fixed fields
# to something that's allowed in a div id.
my $id_subfield = $subfield;
$id_subfield = "00" if $id_subfield eq "@";
my %subfield_data = ( my %subfield_data = (
tag => $tag, tag => $tag,
subfield => $subfield, subfield => $id_subfield,
marc_lib => substr( $tagslib->{$tag}->{$subfield}->{lib}, 0, 22 ), marc_lib => substr( $tagslib->{$tag}->{$subfield}->{lib}, 0, 22 ),
marc_lib_plain => $tagslib->{$tag}->{$subfield}->{lib}, marc_lib_plain => $tagslib->{$tag}->{$subfield}->{lib},
tag_mandatory => $tagslib->{$tag}->{mandatory}, tag_mandatory => $tagslib->{$tag}->{mandatory},
@ -311,16 +317,10 @@ sub create_input {
repeatable => $tagslib->{$tag}->{$subfield}->{repeatable}, repeatable => $tagslib->{$tag}->{$subfield}->{repeatable},
kohafield => $tagslib->{$tag}->{$subfield}->{kohafield}, kohafield => $tagslib->{$tag}->{$subfield}->{kohafield},
index => $index_tag, index => $index_tag,
id => "tag_".$tag."_subfield_".$subfield."_".$index_tag."_".$index_subfield, id => "tag_".$tag."_subfield_".$id_subfield."_".$index_tag."_".$index_subfield,
value => $value, value => $value,
random => CreateKey(), random => CreateKey(),
); );
# deal with a <010 tag
if($subfield eq '@'){
$subfield_data{id} = "tag_".$tag."_subfield_00_".$index_tag."_".$index_subfield;
} else {
$subfield_data{id} = "tag_".$tag."_subfield_".$subfield."_".$index_tag."_".$index_subfield;
}
if(exists $mandatory_z3950->{$tag.$subfield}){ if(exists $mandatory_z3950->{$tag.$subfield}){
$subfield_data{z3950_mandatory} = $mandatory_z3950->{$tag.$subfield}; $subfield_data{z3950_mandatory} = $mandatory_z3950->{$tag.$subfield};
@ -353,7 +353,7 @@ sub create_input {
maxlength=\"255\" maxlength=\"255\"
\/> \/>
<a href=\"#\" class=\"buttonDot\" <a href=\"#\" class=\"buttonDot\"
onclick=\"Dopop('/cgi-bin/koha/authorities/auth_finder.pl?authtypecode=".$tagslib->{$tag}->{$subfield}->{authtypecode}."&index=$subfield_data{id}','$subfield_data{id}'); return false;\" title=\"Tag Editor\">...</a> onclick=\"Dopop('/cgi-bin/koha/authorities/auth_finder.pl?authtypecode=".$tagslib->{$tag}->{$subfield}->{authtypecode}."&amp;index=$subfield_data{id}','$subfield_data{id}'); return false;\" title=\"Tag Editor\">...</a>
"; ";
# it's a plugin field # it's a plugin field
} }
@ -444,8 +444,6 @@ sub create_input {
name=\"".$subfield_data{id}."\" name=\"".$subfield_data{id}."\"
class=\"input_marceditor\" class=\"input_marceditor\"
tabindex=\"1\" tabindex=\"1\"
size=\"67\"
maxlength=\"255\"
>$value</textarea> >$value</textarea>
"; ";
} }
@ -752,7 +750,7 @@ foreach my $thisframeworkcode ( keys %$frameworks ) {
frameworktext => $frameworks->{$thisframeworkcode}->{'frameworktext'}, frameworktext => $frameworks->{$thisframeworkcode}->{'frameworktext'},
); );
if ($frameworkcode eq $thisframeworkcode){ if ($frameworkcode eq $thisframeworkcode){
$row{'selected'}="selected"; $row{'selected'}="selected=\"selected\"";
} }
push @frameworkcodeloop, \%row; push @frameworkcodeloop, \%row;
} }