Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18426: Make sure the logged in user can edit the subscriptions

Browse source 
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2018-04-19 07:25:29 -03:00
parent b366d8d4de
commit 64b689fcc8
2 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
View file

@ -34,15 +34,17 @@
[% ELSE %]
[% SET tab = 'opened' %]
[% END %]
<div class="actions">
<a class="select-all" href="#" data-tab="[% tab %]"><i class="fa fa-check"></i> Select all</a>
|
<a class="clear-all" href="#" data-tab="[% tab %]"><i class="fa fa-remove"></i> Clear all</a>
<span class="itemselection_actions">
| Actions:
<a class="itemselection_action_modify"><i class="fa fa-pencil"></i> Modify selected serials</a>
</span>
</div>
[% IF CAN_user_serials_edit_subscription %]
<div class="actions">
<a class="select-all" href="#" data-tab="[% tab %]"><i class="fa fa-check"></i> Select all</a>
|
<a class="clear-all" href="#" data-tab="[% tab %]"><i class="fa fa-remove"></i> Clear all</a>
<span class="itemselection_actions">
| Actions:
<a class="itemselection_action_modify"><i class="fa fa-pencil"></i> Modify selected serials</a>
</span>
</div>
[% END %]
<table>
<thead>
<tr>
@ -84,7 +86,13 @@
[% FOREACH subscription IN subscriptions %]
[% UNLESS subscription.cannotdisplay %]
<tr>
<td><input type="checkbox" name="subscriptionid" value="[% subscription.subscriptionid %]"/></td>
<td>
[% UNLESS subscription.cannotedit %]
<input type="checkbox" name="subscriptionid" value="[% subscription.subscriptionid %]" />
[% ELSE %]
<input type="checkbox" name="subscriptionid" value="[% subscription.subscriptionid %]" disabled="disabled" title="You cannot edit this subscription" />
[% END %]
</td>
<td>
[% IF ( subscription.issn ) %][% subscription.issn %]
[% END %]

1
serials/subscription-batchedit.pl
View file

@ -69,6 +69,7 @@ if ($batchedit) {
}
foreach my $subscription (@subscriptions) {
next unless C4::Serials::can_edit_subscription( $subscription->unblessed ); # This should be moved to Koha::Subscription->can_edit
while (my ($key, $value) = each %params) {
if (defined $value and $value ne '') {
$subscription->$key($value);