Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34912: Add 14 hours to 1970 date in Account(s).t

Browse source 
This makes those tests pass in whatever timezone.

Test plan:
Do not yet apply patch.
Change timezone on commandline with: export TZ='Etc/GMT-14'
NOTE: GMT-14 is what we also call UTC+14 (sign reversed).
Run prove t/db_dependent/Accounts.t t/db_dependent/Koha/Account.t
This fails now.
Apply patch.
Rerun tests and verify that they pass now.
Bonus: Try some other time zone.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 8d4b10fc84)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit c1078784db)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Marcel de Rooy 2023-09-27 01:45:58 +14:00 committed by Matt Blenkinsop
parent f8c0d379b5
commit 6556450b8d
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
t/db_dependent/Accounts.t
View file

@ -945,7 +945,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub {
my $debit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amountoutstanding => 0,
interface => 'commandline',
debit_type_code => 'LOST'
@ -954,7 +954,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub {
my $credit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amountoutstanding => -5,
interface => 'commandline',
credit_type_code => 'PAYMENT'
@ -978,7 +978,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub {
$debit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amountoutstanding => 5,
interface => 'commanline',
debit_type_code => 'LOST'
@ -987,7 +987,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub {
$credit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amountoutstanding => 0,
interface => 'commandline',
credit_type_code => 'PAYMENT'
@ -1012,7 +1012,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub {
$debit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amountoutstanding => 0,
interface => 'commandline',
debit_type_code => 'LOST'
@ -1021,7 +1021,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub {
$credit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amountoutstanding => 0,
interface => 'commandline',
credit_type_code => 'PAYMENT'

4
t/db_dependent/Koha/Account.t
View file

@ -1127,7 +1127,7 @@ subtest 'Koha::Account::Line::apply() handles lost items' => sub {
my $credit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amount => -.5,
amountoutstanding => -.5,
interface => 'commandline',
@ -1146,7 +1146,7 @@ subtest 'Koha::Account::Line::apply() handles lost items' => sub {
$credit = Koha::Account::Line->new(
{
borrowernumber => $patron->id,
date => '1970-01-01 00:00:01',
date => '1970-01-01 14:00:01',
amount => -.5,
amountoutstanding => -.5,
interface => 'commandline',