Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 30721: Markup error in detail page's component parts tab

Browse source 
This patch adds a missing </div> to the bibliographic detail
page template in the section for showing component parts.
Some comments are added to clarify the markup structure.

To test you should have a record in your catalog with component
parts. Bug 11175 provides one you can import if necessary:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023

To see the error, go to the staff interface, locate the record
in question and view the detail page. Under the Components tag,
scroll to the bottom. You will see content from "later" tabs at
the bottom, e.g. "There is no order for this bibliographic record"
or "No images have been uploaded for this bibliograhpic record yet."

Apply the patch and reload the page. The tabs should still look
correct, and now the tab content should be correctly isolated.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Owen Leonard 2022-05-09 15:22:16 +00:00 committed by Fridolin Somers
parent 0dff67d0df
commit 656e864e6b
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
View file

@ -708,7 +708,8 @@ Note that permanent location is a code, and location may be an authval.
[% IF ComponentParts.size == Koha.Preference('MaxComponentRecords')%]
<p>Only [% ComponentParts.size | html %] results are shown: <a href="/cgi-bin/koha/catalogue/search.pl?q=[% ComponentPartsQuery | uri %]"/>show all component parts</a></p>
[% END %]
</div>
</div> <!-- /.content_set -->
</div> <!-- /#components -->
[% END %]