Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion

Browse source 
When deleting a MARC framework subfield, the confirmation message is not
styled. This patch modifies the template to style the confirmation
message like similar ones.

Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs

To test, apply the patch and go to Administration -> MARC framworks.

 - Click 'MARC structure' for a framework you can edit.
 - Click 'subfields' for a tag you can edit.
 - Click 'Delete' for a subfield you can delete. You should see a
   confirmation dialog styled like other "alert" type dialogs.
 - Test both canceling and confirming deletion to confirm that both
   function correctly.

Revised to fix conflicts with rollback of Bug 13618

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as expected. Revised according with bug revert 13618

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
This commit is contained in:
Owen Leonard 2016-02-11 12:23:49 -05:00 committed by Brendan Gallagher
parent 9bc924d086
commit 659a635412
1 changed files with 22 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
View file

@ -188,25 +188,29 @@
[% IF ( delete_confirm ) %]
<h3>Confirm deletion of subfield [% tagsubfield %]?</h3>
<p>Subfield: [% tagsubfield %]</p>
<p>Description: [% liblibrarian %]</p>
<div class="dialog alert">
<h3>Confirm deletion of subfield [% tagsubfield %]?</h3>
<p>Subfield: [% tagsubfield %]</p>
<p>Description: [% liblibrarian %]</p>
<form action="[% delete_link %]" method="post"><input type="hidden" name="op" value="delete_confirmed" />
<input type="hidden" name="searchfield" value="[% searchfield %]" />
<input type="hidden" name="tagfield" value="[% tagfield | html %]" />
<input type="hidden" name="tagsubfield" value="[% tagsubfield %]" />
<input type="hidden" name="frameworkcode" value="[% frameworkcode %]" />
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete this subfield</button>
</form>
<form action="[% script_name %]" method="post">
<input type="hidden" name="searchfield" value="[% searchfield %]" />
<input type="hidden" name="tagfield" value="[% tagfield | html%]" />
<input type="hidden" name="tagsubfield" value="[% tagsubfield %]" />
<input type="hidden" name="frameworkcode" value="[% frameworkcode %]" />
<button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
</form>
</div>
<form action="[% delete_link %]" method="post"><input type="hidden" name="op" value="delete_confirmed" />
<input type="hidden" name="searchfield" value="[% searchfield %]" />
<input type="hidden" name="tagfield" value="[% tagfield | html %]" />
<input type="hidden" name="tagsubfield" value="[% tagsubfield %]" />
<input type="hidden" name="frameworkcode" value="[% frameworkcode %]" />
<input type="submit" value="Yes, delete this subfield" />
</form>
<form action="[% script_name %]" method="post">
<input type="hidden" name="searchfield" value="[% searchfield %]" />
<input type="hidden" name="tagfield" value="[% tagfield | html %]" />
<input type="hidden" name="tagsubfield" value="[% tagsubfield %]" />
<input type="hidden" name="frameworkcode" value="[% frameworkcode %]" />
<input type="submit" value="No, do not delete" />
</form>
[% END %]
[% IF ( delete_confirmed ) %]