Browse Source

bug 8215: (followup) make sure C4::CourseReserves doesn't export anything

New modules should not export any symbols by default
without a very good reason.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
new/bootstrap-opac
Galen Charlton 9 years ago
parent
commit
65b874bb47
  1. 8
      C4/CourseReserves.pm
  2. 2
      catalogue/detail.pl
  3. 2
      course_reserves/add_items.pl
  4. 2
      course_reserves/course-details.pl
  5. 2
      course_reserves/course-reserves.pl
  6. 2
      course_reserves/course.pl
  7. 2
      course_reserves/mod_course.pl
  8. 2
      opac/opac-course-details.pl
  9. 2
      opac/opac-course-reserves.pl
  10. 2
      opac/opac-detail.pl
  11. 2
      t/db_dependent/CourseReserves.t

8
C4/CourseReserves.pm

@ -17,8 +17,6 @@ package C4::CourseReserves;
use Modern::Perl;
require Exporter;
use C4::Context;
use C4::Items qw(GetItem ModItem);
use C4::Biblio qw(GetBiblioFromItemNumber);
@ -27,8 +25,9 @@ use C4::Circulation qw(GetOpenIssue);
use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG @FIELDS);
BEGIN {
@ISA = qw(Exporter);
@EXPORT = qw(
require Exporter;
@ISA = qw(Exporter);
@EXPORT_OK = qw(
&GetCourse
&ModCourse
&GetCourses
@ -49,6 +48,7 @@ BEGIN {
&GetItemReservesInfo
);
%EXPORT_TAGS = ( 'all' => \@EXPORT_OK );
$DEBUG = 0;
@FIELDS = ( 'itype', 'ccode', 'holdingbranch', 'location' );

2
catalogue/detail.pl

@ -41,7 +41,7 @@ use C4::XSLT;
use C4::Images;
use Koha::DateUtils;
use C4::HTML5Media;
use C4::CourseReserves;
use C4::CourseReserves qw(GetItemReservesInfo);
# use Smart::Comments;

2
course_reserves/add_items.pl

@ -28,7 +28,7 @@ use C4::Koha;
use C4::Biblio;
use C4::Branch;
use C4::CourseReserves;
use C4::CourseReserves qw(GetCourse GetCourseItem GetCourseReserve ModCourseItem ModCourseReserve);
my $cgi = new CGI;

2
course_reserves/course-details.pl

@ -26,7 +26,7 @@ use C4::Auth;
use C4::Output;
use C4::Koha;
use C4::CourseReserves;
use C4::CourseReserves qw(DelCourseReserve GetCourse GetCourseReserves);
my $cgi = new CGI;

2
course_reserves/course-reserves.pl

@ -25,7 +25,7 @@ use CGI;
use C4::Auth;
use C4::Output;
use C4::CourseReserves;
use C4::CourseReserves qw(GetCourses);
my $cgi = new CGI;

2
course_reserves/course.pl

@ -26,7 +26,7 @@ use C4::Auth;
use C4::Output;
use C4::Koha;
use C4::CourseReserves;
use C4::CourseReserves qw(GetCourse);
my $cgi = new CGI;

2
course_reserves/mod_course.pl

@ -25,7 +25,7 @@ use C4::Output;
use C4::Reserves;
use C4::Auth;
use C4::CourseReserves;
use C4::CourseReserves qw(DelCourse ModCourse ModCourseInstructors);
my $cgi = new CGI;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(

2
opac/opac-course-details.pl

@ -26,7 +26,7 @@ use C4::Auth;
use C4::Output;
use C4::Koha;
use C4::CourseReserves;
use C4::CourseReserves qw(GetCourse GetCourseReserves);
my $cgi = new CGI;

2
opac/opac-course-reserves.pl

@ -25,7 +25,7 @@ use CGI;
use C4::Auth;
use C4::Output;
use C4::CourseReserves;
use C4::CourseReserves qw(SearchCourses);
my $cgi = new CGI;

2
opac/opac-detail.pl

@ -50,7 +50,7 @@ use List::MoreUtils qw/any none/;
use C4::Images;
use Koha::DateUtils;
use C4::HTML5Media;
use C4::CourseReserves;
use C4::CourseReserves qw(GetItemReservesInfo);
BEGIN {
if (C4::Context->preference('BakerTaylorEnabled')) {

2
t/db_dependent/CourseReserves.t

@ -11,7 +11,7 @@ use Data::Dumper;
BEGIN {
use_ok('C4::Context');
use_ok('C4::CourseReserves');
use_ok('C4::CourseReserves', qw/:all/);
}
my $dbh = C4::Context->dbh;

Loading…
Cancel
Save