Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29243: Correct call when adding items from staged records

Browse source 
To test:
1 - Populate system preference  NewItemsDefaultLocation
2 - Stage a file of marc records
3 - Create an acquisitions basket with 'AcqCreateItems' set to 'ordering'
4 - Attempt to add to basket from your staged file
5 - You get a 500 error, and in the logs:
    Can't use string ("") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/Items.pm line 1605.
6 - Apply patch
7 - Repeat #4
8 - Success!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2021-10-14 11:30:21 +00:00 committed by Jonathan Druart
parent 31c2bfae5f
commit 66a01d4b47
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
C4/Items.pm
View file

@ -1525,10 +1525,12 @@ sub _find_value {
=head2 PrepareItemrecordDisplay
PrepareItemrecordDisplay($itemrecord,$bibnum,$itemumber,$frameworkcode);
PrepareItemrecordDisplay($bibnum,$itemumber,$defaultvalues,$frameworkcode);
Returns a hash with all the fields for Display a given item data in a template
$defaultvalues should either contain a hashref of values for the new item, or be undefined.
The $frameworkcode returns the item for the given frameworkcode, ONLY if bibnum is not provided
=cut

4
acqui/addorderiso2709.pl
View file

@ -108,11 +108,11 @@ if ($op eq ""){
import_biblios_list($template, $cgiparams->{'import_batch_id'});
if ( $basket->effective_create_items eq 'ordering' && !$basket->is_standing ) {
# prepare empty item form
my $cell = PrepareItemrecordDisplay( '', '', '', 'ACQ' );
my $cell = PrepareItemrecordDisplay( '', '', undef, 'ACQ' );
# warn "==> ".Data::Dumper::Dumper($cell);
unless ($cell) {
$cell = PrepareItemrecordDisplay( '', '', '', '' );
$cell = PrepareItemrecordDisplay( '', '', undef, '' );
$template->param( 'NoACQframework' => 1 );
}
my @itemloop;