Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Squash warnings by checking if $type is defined before comparing it.

Browse source 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This commit is contained in:
Joe Atzberger 2008-10-30 00:10:57 -05:00 committed by Galen Charlton
parent f58319d4e2
commit 679871767f
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
C4/Members.pm
View file

@ -527,7 +527,7 @@ SELECT borrowers.*, categories.category_type, categories.description
FROM borrowers
LEFT JOIN categories on borrowers.categorycode=categories.categorycode
";
if ( defined $type && ( $type eq 'cardnumber' || $type eq 'firstname'|| $type eq 'userid'|| $type eq 'borrowernumber' ) ){
if (defined($type) and ( $type eq 'cardnumber' || $type eq 'firstname'|| $type eq 'userid'|| $type eq 'borrowernumber' ) ){
$information = uc $information;
$sth = $dbh->prepare("$select WHERE $type=?");
} else {
@ -535,14 +535,12 @@ LEFT JOIN categories on borrowers.categorycode=categories.categorycode
}
$sth->execute($information);
my $data = $sth->fetchrow_hashref;
$sth->finish;
($data) and return ($data);
if ($type eq 'cardnumber' || $type eq 'firstname') { # otherwise, try with firstname
if (defined($type) and ($type eq 'cardnumber' || $type eq 'firstname')) { # otherwise, try with firstname
$sth = $dbh->prepare("$select WHERE firstname like ?");
$sth->execute($information);
$data = $sth->fetchrow_hashref;
$sth->finish;
($data) and return ($data);
}
return undef;