Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 39154: Add sip.log test in about

Browse source 
See bug 36954. The file sip.log should not be found anymore in
log4perl.conf.

Test plan:
Edit log4perl.conf. Replace sip-output.log by sip.log.
Check About, tab sysinfo. You should see a warn.
Edit again. Switch back to sip-output.log.
Verify that there is no warn anymore on about.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Marcel de Rooy 2025-02-18 14:30:56 +00:00 committed by Katrin Fischer
parent 9df8986479
commit 67e8825830
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
about.pl
View file

@ -826,7 +826,9 @@ sub log4perl_check {
for my $line (@lines) { for my $line (@lines) {
next unless $line =~ m|log4perl\.appender\.\w+\.filename=(.*)|; next unless $line =~ m|log4perl\.appender\.\w+\.filename=(.*)|;
my $file = $1; my $file = $1;
if ( !-w $file ) { if ( $file =~ /sip\.log$/ ) {
push @log4perl_errors, 'sip_log_still_found';
} elsif ( !-w $file ) {
push @log4perl_errors, 'logfile_not_writable'; push @log4perl_errors, 'logfile_not_writable';
#NOTE: An unwritable logfile blocks plack.psgi. So you won't reach this script. (BZ 39155) #NOTE: An unwritable logfile blocks plack.psgi. So you won't reach this script. (BZ 39155)

2
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
View file

@ -449,6 +449,8 @@
<span>One of the logfiles listed in the config file is not writable.</span> <span>One of the logfiles listed in the config file is not writable.</span>
[% CASE 'cannot_init_module' %] [% CASE 'cannot_init_module' %]
<span>The Koha::Logger module cannot be initiated correctly (check the log file).</span> <span>The Koha::Logger module cannot be initiated correctly (check the log file).</span>
[% CASE 'sip_log_still_found' %]
<span>Config file log4perl.conf still refers to sip.log (instead of sip-output.log).</span>
[% CASE %] [% CASE %]
<span>Unknown error '[% e | html %]'.</span> <span>Unknown error '[% e | html %]'.</span>
[% END %] [% END %]