Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33238: Fix bad suggestions query (Bug 29886 follow-up)

Browse source 
With IndependentBranches Koha explodes with Error 500 when a non
superlibrarian tries to add to basket from suggestions.  In errorlog you
would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
DBD::mysql::st execute failed: Column 'branchcode' in where clause is
ambiguous".

Test plan:
==========
1. Have a Koha instance with IndependentBranches, some accepted
   suggestions, and a vendor defined.
2. Be a non superlibrarian librarian with permissions to
   manage acquisitions.
3. Create a new basket and try to add an item to the basket
   "From a suggestion".
4. Koha would generate error 500.
5. Apply the patch.
6. Try to add an item to the basket "From a suggestion".
7. You should succeed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Janusz Kaczmarek 2023-03-15 20:25:53 +01:00 committed by Tomas Cohen Arazi
parent 1344050ab4
commit 68b2f29d48
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Suggestions.pm
View file

@ -56,7 +56,7 @@ sub search_limited {
# from other libraries)
my $userenv = C4::Context->userenv;
$resultset = $self->search({ branchcode => $userenv->{branch} })
$resultset = $self->search({ 'me.branchcode' => $userenv->{branch} })
if $userenv && $userenv->{branch};
}