Bug 24621: Phase out jquery.cookie.js: Basic MARC editor
This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply the patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
parent
b11678b905
commit
6a2f70b7e3
1 changed files with 9 additions and 9 deletions
|
@ -47,14 +47,14 @@
|
|||
});
|
||||
|
||||
/* check cookie to hide/show marcdocs*/
|
||||
if($.cookie("marcdocs_[% borrowernumber | html %]") == 'hide'){
|
||||
if( Cookies.get("marcdocs_[% borrowernumber | html %]") == 'hide'){
|
||||
toggleMARCdocLinks(false);
|
||||
} else {
|
||||
toggleMARCdocLinks(true);
|
||||
}
|
||||
|
||||
$("#marcDocsSelect").click(function(){
|
||||
if($.cookie("marcdocs_[% borrowernumber | html %]") == 'hide'){
|
||||
if( Cookies.get("marcdocs_[% borrowernumber | html %]") == 'hide'){
|
||||
toggleMARCdocLinks(true);
|
||||
} else {
|
||||
toggleMARCdocLinks(false);
|
||||
|
@ -62,7 +62,7 @@
|
|||
});
|
||||
|
||||
/* check cookie to hide/show marc tags*/
|
||||
var marctags_cookie = $.cookie("marctags_[% borrowernumber | html %]");
|
||||
var marctags_cookie = Cookies.get("marctags_[% borrowernumber | html %]");
|
||||
if( marctags_cookie == 'hide'){
|
||||
toggleMARCTagLinks(false);
|
||||
} else if( marctags_cookie == 'show'){
|
||||
|
@ -76,7 +76,7 @@
|
|||
}
|
||||
|
||||
$("#marcTagsSelect").click(function(){
|
||||
if( $.cookie("marctags_[% borrowernumber | html %]") == 'hide'){
|
||||
if( Cookies.get("marctags_[% borrowernumber | html %]") == 'hide'){
|
||||
toggleMARCTagLinks(true)
|
||||
} else {
|
||||
toggleMARCTagLinks(false);
|
||||
|
@ -125,7 +125,7 @@
|
|||
|
||||
if ( !confirm( breedingid ? _("This record cannot be transferred to the advanced editor. Continue?") : _("Any changes will not be saved. Continue?") ) ) return false;
|
||||
|
||||
$.cookie( 'catalogue_editor_[% logged_in_user.borrowernumber | html %]', 'advanced', { expires: 365, path: '/' } );
|
||||
Cookies.set( 'catalogue_editor_[% logged_in_user.borrowernumber | html %]', 'advanced', { expires: 365, path: '/' } );
|
||||
|
||||
var biblionumber = [% biblionumber || "null" | html %];
|
||||
|
||||
|
@ -260,11 +260,11 @@
|
|||
function toggleMARCdocLinks(flag){
|
||||
if( flag === true ){
|
||||
$(".marcdocs").show();
|
||||
$.cookie("marcdocs_[% borrowernumber | html %]",'show', { path: "/", expires: 365 });
|
||||
Cookies.set("marcdocs_[% borrowernumber | html %]",'show', { path: "/", expires: 365 });
|
||||
$("#marcDocsSelect i").addClass('fa-check-square-o').removeClass('fa-square-o');
|
||||
} else {
|
||||
$(".marcdocs").hide();
|
||||
$.cookie("marcdocs_[% borrowernumber | html %]",'hide', { path: "/", expires: 365 });
|
||||
Cookies.set("marcdocs_[% borrowernumber | html %]",'hide', { path: "/", expires: 365 });
|
||||
$("#marcDocsSelect i").removeClass('fa-check-square-o').addClass('fa-square-o');
|
||||
}
|
||||
}
|
||||
|
@ -273,12 +273,12 @@
|
|||
if( flag === true ){
|
||||
$(".tagnum").show();
|
||||
$(".subfieldcode").show();
|
||||
$.cookie("marctags_[% borrowernumber | html %]",'show', { path: "/", expires: 365 });
|
||||
Cookies.set("marctags_[% borrowernumber | html %]",'show', { path: "/", expires: 365 });
|
||||
$("#marcTagsSelect i").addClass('fa-check-square-o').removeClass('fa-square-o');
|
||||
} else {
|
||||
$(".tagnum").hide();
|
||||
$(".subfieldcode").hide();
|
||||
$.cookie("marctags_[% borrowernumber | html %]",'hide', { path: "/", expires: 365 });
|
||||
Cookies.set("marctags_[% borrowernumber | html %]",'hide', { path: "/", expires: 365 });
|
||||
$("#marcTagsSelect i").removeClass('fa-check-square-o').addClass('fa-square-o');
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue