Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31848: Correct margin and padding on action fieldset in aside

Browse source 
This patch makes a minor modification to the padding and margin of
<fieldset class="action"> nested in a .brief fieldset. This markup is
seen most often in sidebar filter form. The change allows the submit
button to line up better with other form fields.

The patch also corrects and inconsistency by modifying the holds queue
template so that the .action fieldset is inside the .brief fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- If necessary, place one or more holds for pickup at your logged-in
  library and rebuild the holds queue
  (misc/cronjobs/holds/build_holds_queue.pl)
- Go to Circulation -> Holds queue.
- The form should look correct.
- Submit the form and check the form in the sidebar. It should look
  correct as well, with the submit button aligned left with the other
  form fields.
- Check pages with similar sidebar forms, e.g.:
  - Administration -> Budgets -> Funds -> Planning
  - Circulation -> Overdues
  - Circulation -> Holds to pull
  - Acquisitions -> Invoices -> Search results

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2022-10-18 12:07:38 +00:00 committed by Tomas Cohen Arazi
parent 62e2210b82
commit 6aef35b07e
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
View file

@ -944,7 +944,8 @@ fieldset {
}
.action {
margin-left: 1em;
margin: 0;
padding: .4em 0;
}
}

8
koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
View file

@ -283,10 +283,10 @@
</select>
</li>
</ol>
</fieldset>
<fieldset class="action">
<input type="submit" value="Submit" />
<input type="hidden" name="run_report" value="1" />
<fieldset class="action">
<input type="submit" value="Submit" />
<input type="hidden" name="run_report" value="1" />
</fieldset>
</fieldset>
</form>
[% END %]