Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

GetMarcFromKohaField needs 2 args, or there's no point.

Browse source 
GetMarcFromKohaField returns (0,0) without the $frameworkcode argument.
Note the argument can be "", but it must not be undefined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This commit is contained in:
Joe Atzberger 2009-02-04 15:55:49 -06:00 committed by Galen Charlton
parent eaa3ee40a7
commit 6b9b778b1b
2 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
C4/Biblio.pm
View file

@ -2217,7 +2217,7 @@ sub _DelBiblioNoZebra {
if ($server eq 'biblioserver') {
%index=GetNoZebraIndexes;
# get title of the record (to store the 10 first letters with the index)
my ($titletag,$titlesubfield) = GetMarcFromKohaField('biblio.title');
my ($titletag,$titlesubfield) = GetMarcFromKohaField('biblio.title', ''); # FIXME: should be GetFrameworkCode($biblionumber) ??
$title = lc($record->subfield($titletag,$titlesubfield));
} else {
# for authorities, the "title" is the $a mainentry
@ -2311,7 +2311,7 @@ sub _AddBiblioNoZebra {
if ($server eq 'biblioserver') {
%index=GetNoZebraIndexes;
# get title of the record (to store the 10 first letters with the index)
my ($titletag,$titlesubfield) = GetMarcFromKohaField('biblio.title');
my ($titletag,$titlesubfield) = GetMarcFromKohaField('biblio.title', ''); # FIXME: should be GetFrameworkCode($biblionumber) ??
$title = lc($record->subfield($titletag,$titlesubfield));
} else {
# warn "server : $server";

16
C4/Search.pm
View file

@ -1947,15 +1947,13 @@ sub NZorder {
my ( $biblionumber, $title ) = split /,/, $_;
my $record = GetMarcBiblio($biblionumber);
my $callnumber;
my ( $callnumber_tag, $callnumber_subfield ) =
GetMarcFromKohaField( $dbh, 'items.itemcallnumber' );
( $callnumber_tag, $callnumber_subfield ) =
GetMarcFromKohaField('biblioitems.callnumber')
unless $callnumber_tag;
my $frameworkcode = GetFrameworkCode($biblionumber);
my ( $callnumber_tag, $callnumber_subfield ) = GetMarcFromKohaField( 'items.itemcallnumber', $frameworkcode);
( $callnumber_tag, $callnumber_subfield ) = GetMarcFromKohaField('biblioitems.callnumber', $frameworkcode)
unless $callnumber_tag;
if ( C4::Context->preference('marcflavour') eq 'UNIMARC' ) {
$callnumber = $record->subfield( '200', 'f' );
}
else {
} else {
$callnumber = $record->subfield( '100', 'a' );
}
@ -2169,8 +2167,8 @@ sub ModBiblios {
$tag = $tag . $subfield;
undef $subfield;
}
my ( $bntag, $bnsubf ) = GetMarcFromKohaField('biblio.biblionumber');
my ( $itemtag, $itemsubf ) = GetMarcFromKohaField('items.itemnumber');
my ( $bntag, $bnsubf ) = GetMarcFromKohaField('biblio.biblionumber', '');
my ( $itemtag, $itemsubf ) = GetMarcFromKohaField('items.itemnumber', '');
if ($tag eq $itemtag) {
# do not allow the embedded item tag to be
# edited from here